[Discover] Update sidebar flaky tests (#180724)

- Closes #180564 - Closes #180693 25x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5671
elastic · Apr 16, 2024 · 6184129 · 6184129
1 parent 09155fa
commit 6184129
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 0 deletions.
diff --git a/test/functional/apps/discover/group3/_lens_vis.ts b/test/functional/apps/discover/group3/_lens_vis.ts
@@ -169,6 +169,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         hasTimeField: true,
         changeTimestampField: `--- I don't want to use the time filter ---`,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await checkNoVis(defaultTotalCount);
 
       await dataViews.editFromSearchBar({ newName: 'logs', newTimeField: '@timestamp' });

diff --git a/test/functional/apps/discover/group3/_panels_toggle.ts b/test/functional/apps/discover/group3/_panels_toggle.ts
@@ -211,6 +211,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           adHoc: true,
           hasTimeField: false,
         });
+        await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
       });
 
@@ -259,6 +260,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           adHoc: true,
           hasTimeField: false,
         });
+        await PageObjects.discover.waitUntilSearchingHasFinished();
         await PageObjects.discover.selectTextBaseLang();
         await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
       });

diff --git a/test/functional/apps/discover/group3/_sidebar.ts b/test/functional/apps/discover/group3/_sidebar.ts
@@ -645,6 +645,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           adHoc: true,
           hasTimeField: true,
         });
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
+
         expect(await PageObjects.unifiedFieldList.getSidebarAriaDescription()).to.be(
           INITIAL_FIELD_LIST_SUMMARY
         );

diff --git a/test/functional/apps/discover/group4/_adhoc_data_views.ts b/test/functional/apps/discover/group4/_adhoc_data_views.ts
@@ -63,6 +63,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         adHoc: true,
         hasTimeField: true,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       const first = await PageObjects.discover.getCurrentDataViewId();
 
       await PageObjects.discover.addRuntimeField(
@@ -145,6 +146,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         adHoc: true,
         hasTimeField: true,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       const prevDataViewId = await PageObjects.discover.getCurrentDataViewId();
 
       // trigger data view id update
@@ -243,6 +245,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         adHoc: true,
         hasTimeField: true,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await filterBar.addFilter({
         field: 'nestedField.child',
         operation: 'is',

diff --git a/test/functional/apps/discover/group4/_data_view_edit.ts b/test/functional/apps/discover/group4/_data_view_edit.ts
@@ -80,6 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         hasTimeField: true,
       });
       await dataViews.waitForSwitcherToBe(`${initialPattern}*`);
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
 
       expect(await PageObjects.discover.getHitCountInt()).to.be(2);
@@ -93,6 +94,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         adHoc: false,
         hasTimeField: true,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
 
       await retry.try(async () => {
         expect(await PageObjects.discover.getHitCountInt()).to.be(1);

diff --git a/test/functional/apps/discover/group4/_field_list_new_fields.ts b/test/functional/apps/discover/group4/_field_list_new_fields.ts
@@ -59,6 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         hasTimeField: true,
       });
       await dataViews.waitForSwitcherToBe(`${initialPattern}*`);
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
 
       expect(await PageObjects.discover.getHitCountInt()).to.be(1);
@@ -106,6 +107,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         hasTimeField: true,
       });
       await dataViews.waitForSwitcherToBe(`${initialPattern}*`);
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
 
       expect(await PageObjects.discover.getHitCountInt()).to.be(1);

diff --git a/test/functional/apps/discover/group4/_new_search.ts b/test/functional/apps/discover/group4/_new_search.ts
@@ -67,8 +67,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         adHoc: true,
         hasTimeField: true,
       });
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await filterBar.addFilter({ field: 'extension', operation: 'is', value: 'css' });
       await PageObjects.header.waitUntilLoadingHasFinished();
+      await PageObjects.discover.waitUntilSearchingHasFinished();
       await queryBar.setQuery('bytes > 100');
       await queryBar.submitQuery();
       await PageObjects.header.waitUntilLoadingHasFinished();

diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_sidebar.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_sidebar.ts
@@ -549,6 +549,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           hasTimeField: true,
         });
 
+        await PageObjects.discover.waitUntilSearchingHasFinished();
+        await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
+
         expect(await PageObjects.unifiedFieldList.getSidebarAriaDescription()).to.be(
           INITIAL_FIELD_LIST_SUMMARY
         );