[ML] change naming for shared services

elastic · Jul 20, 2021 · 5f886cb · 5f886cb
1 parent 4c6d17e
commit 5f886cb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/x-pack/plugins/ml/server/plugin.ts b/x-pack/plugins/ml/server/plugin.ts
@@ -196,7 +196,7 @@ export class MlServerPlugin
 
     initMlServerLog({ log: this.log });
 
-    const { mlServicesProviders, shared } = createSharedServices(
+    const { internalServicesProviders, sharedServicesProviders } = createSharedServices(
       this.mlLicense,
       getSpaces,
       plugins.cloud,
@@ -211,16 +211,16 @@ export class MlServerPlugin
       registerMlAlerts({
         alerting: plugins.alerting,
         logger: this.log,
-        mlSharedServices: shared,
-        mlServicesProviders,
+        mlSharedServices: sharedServicesProviders,
+        mlServicesProviders: internalServicesProviders,
       });
     }
 
     if (plugins.usageCollection) {
       registerCollector(plugins.usageCollection, this.kibanaIndexConfig.kibana.index);
     }
 
-    return shared;
+    return sharedServicesProviders;
   }
 
   public start(coreStart: CoreStart): MlPluginStart {

diff --git a/x-pack/plugins/ml/server/shared_services/shared_services.ts b/x-pack/plugins/ml/server/shared_services/shared_services.ts
@@ -78,8 +78,8 @@ export function createSharedServices(
   getInternalSavedObjectsClient: () => SavedObjectsClientContract | null,
   isMlReady: () => Promise<void>
 ): {
-  shared: SharedServices;
-  mlServicesProviders: MlServicesProviders;
+  sharedServicesProviders: SharedServices;
+  internalServicesProviders: MlServicesProviders;
 } {
   const { isFullLicense, isMinimumLicense } = licenseChecks(mlLicense);
   function getGuards(
@@ -128,9 +128,9 @@ export function createSharedServices(
 
   return {
     /**
-     * Exposed shared services for other plugins
+     * Exposed providers for shared services used by other plugins
      */
-    shared: {
+    sharedServicesProviders: {
       ...getJobServiceProvider(getGuards),
       ...getAnomalyDetectorsProvider(getGuards),
       ...getModulesProvider(getGuards),
@@ -139,9 +139,9 @@ export function createSharedServices(
       ...getAlertingServiceProvider(getGuards),
     },
     /**
-     * Services for ML internal usage
+     * Services providers for ML internal usage
      */
-    mlServicesProviders: {
+    internalServicesProviders: {
       ...getJobsHealthServiceProvider(getGuards),
     },
   };