[Canvas] Repeat image bug with image height fixed. (#121497)

* Fixed typo and increased performance. Co-authored-by: Kibana Machine <[email protected]>
elastic · Dec 22, 2021 · 5dc03d0 · 5dc03d0
1 parent e69b1d9
commit 5dc03d0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/plugins/expression_repeat_image/public/components/repeat_image_component.tsx b/src/plugins/expression_repeat_image/public/components/repeat_image_component.tsx
@@ -49,7 +49,7 @@ function createImageJSX(img: HTMLImageElement | null) {
   if (!img) {
     return null;
   }
-  const params = img.width > img.height ? { heigth: img.height } : { width: img.width };
+  const params = img.width > img.height ? { height: img.height } : { width: img.width };
   return <img src={img.src} {...params} alt="" />;
 }
 
@@ -82,12 +82,14 @@ function RepeatImageComponent({
 
   if (image) {
     setImageSize(image, size);
-    times(count, () => imagesToRender.push(createImageJSX(image)));
+    const imgJSX = createImageJSX(image);
+    times(count, () => imagesToRender.push(imgJSX));
   }
 
   if (emptyImage) {
     setImageSize(emptyImage, size);
-    times(max - count, () => imagesToRender.push(createImageJSX(emptyImage)));
+    const imgJSX = createImageJSX(emptyImage);
+    times(max - count, () => imagesToRender.push(imgJSX));
   }
 
   return (