Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.x] [Security Solution] Unskip perform bulk action ESS FTR tests (#…
…197660) (#198909) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Unskip perform bulk action ESS FTR tests (#197660)](#197660) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T10:24:37Z","message":"[Security Solution] Unskip perform bulk action ESS FTR tests (#197660)\n\n**Closes: https://github.com/elastic/kibana/issues/196470**\r\n**Closes: https://github.com/elastic/kibana/issues/196462**\r\n\r\n## Summary\r\n\r\nThis PR unskips `perform_bulk_action_ess.ts` functional test.\r\n\r\n## Details\r\n\r\n`perform_bulk_action_ess.ts` includes a number of functional tests where some of them were flaky. Investigation revealed that creating enabled rules and performing bulk actions may lead to race conditions. Under that conditions rule's SO isn't updated as expected. For example legacy rule actions aren't persisted in rule's SO when it's expected by the test.\r\n\r\nThis PR includes `perform_bulk_action_ess.ts` refactoring to create disabled rules in the majority of tests. Enabled rules are created only in tests checking behavior upon rules disabling. These tests were checked multiple times and didn't demonstrate flakiness.\r\n\r\nAdditionally `@kbn/expect` was replaced with `expect` to make asserting more transparent and avoid unclear error messages. \r\n\r\n## Flaky test results\r\n\r\n[100 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7274) 🟢","sha":"bf37a019d857e89d6dad3a6cf450ec323f0783e0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","failed-test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:prev-major"],"title":"[Security Solution] Unskip perform bulk action ESS FTR tests","number":197660,"url":"https://github.com/elastic/kibana/pull/197660","mergeCommit":{"message":"[Security Solution] Unskip perform bulk action ESS FTR tests (#197660)\n\n**Closes: https://github.com/elastic/kibana/issues/196470**\r\n**Closes: https://github.com/elastic/kibana/issues/196462**\r\n\r\n## Summary\r\n\r\nThis PR unskips `perform_bulk_action_ess.ts` functional test.\r\n\r\n## Details\r\n\r\n`perform_bulk_action_ess.ts` includes a number of functional tests where some of them were flaky. Investigation revealed that creating enabled rules and performing bulk actions may lead to race conditions. Under that conditions rule's SO isn't updated as expected. For example legacy rule actions aren't persisted in rule's SO when it's expected by the test.\r\n\r\nThis PR includes `perform_bulk_action_ess.ts` refactoring to create disabled rules in the majority of tests. Enabled rules are created only in tests checking behavior upon rules disabling. These tests were checked multiple times and didn't demonstrate flakiness.\r\n\r\nAdditionally `@kbn/expect` was replaced with `expect` to make asserting more transparent and avoid unclear error messages. \r\n\r\n## Flaky test results\r\n\r\n[100 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7274) 🟢","sha":"bf37a019d857e89d6dad3a6cf450ec323f0783e0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197660","number":197660,"mergeCommit":{"message":"[Security Solution] Unskip perform bulk action ESS FTR tests (#197660)\n\n**Closes: https://github.com/elastic/kibana/issues/196470**\r\n**Closes: https://github.com/elastic/kibana/issues/196462**\r\n\r\n## Summary\r\n\r\nThis PR unskips `perform_bulk_action_ess.ts` functional test.\r\n\r\n## Details\r\n\r\n`perform_bulk_action_ess.ts` includes a number of functional tests where some of them were flaky. Investigation revealed that creating enabled rules and performing bulk actions may lead to race conditions. Under that conditions rule's SO isn't updated as expected. For example legacy rule actions aren't persisted in rule's SO when it's expected by the test.\r\n\r\nThis PR includes `perform_bulk_action_ess.ts` refactoring to create disabled rules in the majority of tests. Enabled rules are created only in tests checking behavior upon rules disabling. These tests were checked multiple times and didn't demonstrate flakiness.\r\n\r\nAdditionally `@kbn/expect` was replaced with `expect` to make asserting more transparent and avoid unclear error messages. \r\n\r\n## Flaky test results\r\n\r\n[100 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7274) 🟢","sha":"bf37a019d857e89d6dad3a6cf450ec323f0783e0"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <[email protected]>
- Loading branch information