Skip to content

Commit

Permalink
[Stateful sidenav] Remove analytics IA group (#181132)
Browse files Browse the repository at this point in the history
  • Loading branch information
sebelga authored Apr 18, 2024
1 parent 0956f53 commit 5be49ca
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 263 deletions.
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,6 @@ packages/kbn-shared-ux-utility @elastic/appex-sharedux
x-pack/plugins/observability_solution/slo @elastic/obs-ux-management-team
x-pack/packages/kbn-slo-schema @elastic/obs-ux-management-team
x-pack/plugins/snapshot_restore @elastic/kibana-management
packages/solution-nav/analytics @elastic/appex-sharedux @elastic/kibana-data-discovery @elastic/kibana-presentation @elastic/kibana-visualizations
packages/solution-nav/es @elastic/appex-sharedux @elastic/enterprise-search-frontend
packages/solution-nav/oblt @elastic/appex-sharedux @elastic/obs-ux-management-team
packages/kbn-some-dev-log @elastic/kibana-operations
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,6 @@
"@kbn/slo-plugin": "link:x-pack/plugins/observability_solution/slo",
"@kbn/slo-schema": "link:x-pack/packages/kbn-slo-schema",
"@kbn/snapshot-restore-plugin": "link:x-pack/plugins/snapshot_restore",
"@kbn/solution-nav-analytics": "link:packages/solution-nav/analytics",
"@kbn/solution-nav-es": "link:packages/solution-nav/es",
"@kbn/solution-nav-oblt": "link:packages/solution-nav/oblt",
"@kbn/sort-predicates": "link:packages/kbn-sort-predicates",
Expand Down
3 changes: 0 additions & 3 deletions packages/solution-nav/analytics/README.md

This file was deleted.

185 changes: 0 additions & 185 deletions packages/solution-nav/analytics/definition.ts

This file was deleted.

9 changes: 0 additions & 9 deletions packages/solution-nav/analytics/index.ts

This file was deleted.

13 changes: 0 additions & 13 deletions packages/solution-nav/analytics/jest.config.js

This file was deleted.

10 changes: 0 additions & 10 deletions packages/solution-nav/analytics/kibana.jsonc

This file was deleted.

6 changes: 0 additions & 6 deletions packages/solution-nav/analytics/package.json

This file was deleted.

22 changes: 0 additions & 22 deletions packages/solution-nav/analytics/tsconfig.json

This file was deleted.

2 changes: 1 addition & 1 deletion src/plugins/navigation/public/plugin.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ describe('Navigation Plugin', () => {

expect(coreStart.chrome.project.updateSolutionNavigations).toHaveBeenCalled();
const [arg] = coreStart.chrome.project.updateSolutionNavigations.mock.calls[0];
expect(Object.keys(arg)).toEqual(['es', 'oblt', 'analytics']);
expect(Object.keys(arg)).toEqual(['es', 'oblt']);

expect(coreStart.chrome.project.changeActiveSolutionNavigation).toHaveBeenCalledWith(null);
});
Expand Down
5 changes: 0 additions & 5 deletions src/plugins/navigation/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import type {
import { InternalChromeStart } from '@kbn/core-chrome-browser-internal';
import { definition as esDefinition } from '@kbn/solution-nav-es';
import { definition as obltDefinition } from '@kbn/solution-nav-oblt';
import { definition as analyticsDefinition } from '@kbn/solution-nav-analytics';
import type { PanelContentProvider } from '@kbn/shared-ux-chrome-navigation';
import { UserProfileData } from '@kbn/user-profile-components';
import { ENABLE_SOLUTION_NAV_UI_SETTING_ID, SOLUTION_NAV_FEATURE_FLAG_NAME } from '../common';
Expand Down Expand Up @@ -283,10 +282,6 @@ export class NavigationPublicPlugin
...obltDefinition,
sideNavComponent: this.getSideNavComponent({ dataTestSubj: 'observabilitySideNav' }),
},
analytics: {
...analyticsDefinition,
sideNavComponent: this.getSideNavComponent({ dataTestSubj: 'analyticsSideNav' }),
},
};
chrome.project.updateSolutionNavigations(solutionNavs, true);
}
Expand Down
1 change: 0 additions & 1 deletion src/plugins/navigation/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"@kbn/solution-nav-es",
"@kbn/solution-nav-oblt",
"@kbn/config",
"@kbn/solution-nav-analytics",
"@kbn/security-plugin",
"@kbn/user-profile-components",
"@kbn/core-lifecycle-browser",
Expand Down
2 changes: 0 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1600,8 +1600,6 @@
"@kbn/slo-schema/*": ["x-pack/packages/kbn-slo-schema/*"],
"@kbn/snapshot-restore-plugin": ["x-pack/plugins/snapshot_restore"],
"@kbn/snapshot-restore-plugin/*": ["x-pack/plugins/snapshot_restore/*"],
"@kbn/solution-nav-analytics": ["packages/solution-nav/analytics"],
"@kbn/solution-nav-analytics/*": ["packages/solution-nav/analytics/*"],
"@kbn/solution-nav-es": ["packages/solution-nav/es"],
"@kbn/solution-nav-es/*": ["packages/solution-nav/es/*"],
"@kbn/solution-nav-oblt": ["packages/solution-nav/oblt"],
Expand Down
4 changes: 0 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6252,10 +6252,6 @@
version "0.0.0"
uid ""

"@kbn/solution-nav-analytics@link:packages/solution-nav/analytics":
version "0.0.0"
uid ""

"@kbn/solution-nav-es@link:packages/solution-nav/es":
version "0.0.0"
uid ""
Expand Down

0 comments on commit 5be49ca

Please sign in to comment.