refactor to use EuiOutsideClickDetector

elastic · Jan 12, 2021 · 587153d · 587153d
1 parent 4cb666a
commit 587153d
Showing 1 changed file with 18 additions and 23 deletions.
diff --git a/src/plugins/vis_type_xy/public/utils/use_color_picker.tsx b/src/plugins/vis_type_xy/public/utils/use_color_picker.tsx
@@ -17,10 +17,11 @@
  * under the License.
  */
 
-import React, { BaseSyntheticEvent, useCallback, useEffect, useMemo, useRef } from 'react';
+import React, { BaseSyntheticEvent, useCallback, useMemo, useRef } from 'react';
 
 import { LegendColorPicker, Position, XYChartSeriesIdentifier, SeriesName } from '@elastic/charts';
-import { PopoverAnchorPosition, EuiWrappingPopover } from '@elastic/eui';
+import { PopoverAnchorPosition, EuiWrappingPopover, EuiOutsideClickDetector } from '@elastic/eui';
+import { EuiEvent } from '@elastic/eui/src/components/outside_click_detector/outside_click_detector';
 
 import { ColorPicker } from '../../../charts/public';
 
@@ -65,35 +66,29 @@ export const useColorPicker = (
 
       // eslint-disable-next-line react-hooks/rules-of-hooks
       const handleOutsideClick = useCallback(
-        (e: MouseEvent) => {
+        (e: EuiEvent) => {
           if (ref.current && !(ref.current! as any).contains(e.target)) {
             onClose?.();
           }
         },
         [onClose]
       );
 
-      // eslint-disable-next-line react-hooks/rules-of-hooks
-      useEffect(() => {
-        document.addEventListener('click', handleOutsideClick);
-        return () => {
-          document.removeEventListener('click', handleOutsideClick);
-        };
-      }, [handleOutsideClick]);
-
       return (
-        <EuiWrappingPopover
-          popoverRef={ref}
-          isOpen
-          ownFocus
-          display="block"
-          button={anchor}
-          anchorPosition={getAnchorPosition(legendPosition)}
-          closePopover={onClose}
-          panelPaddingSize="s"
-        >
-          <ColorPicker color={color} onChange={handlChange} label={seriesName} />
-        </EuiWrappingPopover>
+        <EuiOutsideClickDetector onOutsideClick={handleOutsideClick}>
+          <EuiWrappingPopover
+            popoverRef={ref}
+            isOpen
+            ownFocus
+            display="block"
+            button={anchor}
+            anchorPosition={getAnchorPosition(legendPosition)}
+            closePopover={onClose}
+            panelPaddingSize="s"
+          >
+            <ColorPicker color={color} onChange={handlChange} label={seriesName} />
+          </EuiWrappingPopover>
+        </EuiOutsideClickDetector>
       );
     },
     [getSeriesName, legendPosition, setColor]