[Lens] Remove "inside only" option for treemap labels (#65363) (#65574)

* [Lens] Remove "inside only" option for treemap labels * Fix type error * Update from feedback
elastic · May 6, 2020 · 5826ac4 · 5826ac4
1 parent 8dd1fa5
commit 5826ac4
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 3 deletions.
diff --git a/x-pack/plugins/lens/public/pie_visualization/render_function.tsx b/x-pack/plugins/lens/public/pie_visualization/render_function.tsx
@@ -109,7 +109,10 @@ export function PieComponent(
         return String(d);
       },
       fillLabel:
-        isDarkMode && shape === 'treemap' && layerIndex < columnGroups.length - 1
+        isDarkMode &&
+        shape === 'treemap' &&
+        layerIndex < columnGroups.length - 1 &&
+        categoryDisplay !== 'hide'
           ? { ...fillLabel, textColor: euiDarkVars.euiTextColor }
           : fillLabel,
       shape: {
@@ -252,6 +255,7 @@ export function PieComponent(
           valueFormatter={(d: number) => (hideLabels ? '' : formatters[metricColumn.id].convert(d))}
           layers={layers}
           config={config}
+          topGroove={hideLabels || categoryDisplay === 'hide' ? 0 : undefined}
         />
       </Chart>
     </VisualizationContainer>

diff --git a/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx b/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx
@@ -66,6 +66,24 @@ const categoryOptions: Array<{
   },
 ];
 
+const categoryOptionsTreemap: Array<{
+  value: SharedLayerState['categoryDisplay'];
+  inputDisplay: string;
+}> = [
+  {
+    value: 'default',
+    inputDisplay: i18n.translate('xpack.lens.pieChart.showTreemapCategoriesLabel', {
+      defaultMessage: 'Show labels',
+    }),
+  },
+  {
+    value: 'hide',
+    inputDisplay: i18n.translate('xpack.lens.pieChart.categoriesInLegendLabel', {
+      defaultMessage: 'Hide labels',
+    }),
+  },
+];
+
 const legendOptions: Array<{
   value: SharedLayerState['legendDisplay'];
   label: string;
@@ -113,7 +131,7 @@ export function SettingsWidget(props: VisualizationLayerWidgetProps<PieVisualiza
         <EuiSuperSelect
           compressed
           valueOfSelected={layer.categoryDisplay}
-          options={categoryOptions}
+          options={state.shape === 'treemap' ? categoryOptionsTreemap : categoryOptions}
           onChange={option => {
             setState({
               ...state,

diff --git a/x-pack/plugins/lens/public/pie_visualization/suggestions.test.ts b/x-pack/plugins/lens/public/pie_visualization/suggestions.test.ts
@@ -508,7 +508,7 @@ describe('suggestions', () => {
                 metric: 'b',
 
                 numberDisplay: 'hidden',
-                categoryDisplay: 'inside',
+                categoryDisplay: 'default', // This is changed
                 legendDisplay: 'show',
                 percentDecimals: 0,
                 nestedLegend: true,

diff --git a/x-pack/plugins/lens/public/pie_visualization/suggestions.ts b/x-pack/plugins/lens/public/pie_visualization/suggestions.ts
@@ -115,6 +115,10 @@ export function suggestions({
                 layerId: table.layerId,
                 groups: groups.map(col => col.columnId),
                 metric: metrics[0].columnId,
+                categoryDisplay:
+                  state.layers[0].categoryDisplay === 'inside'
+                    ? 'default'
+                    : state.layers[0].categoryDisplay,
               }
             : {
                 layerId: table.layerId,