Skip to content

Commit

Permalink
replace hard coded values with constant
Browse files Browse the repository at this point in the history
  • Loading branch information
dominiqueclarke committed Oct 5, 2021
1 parent 9d054f8 commit 5620f14
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ export class LensAttributes {
layers[layerId] = {
columnOrder: [
`x-axis-column-${layerId}`,
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN && breakdown !== 'percentile'
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN && breakdown !== PERCENTILE
? [`breakdown-column-${layerId}`]
: []),
`y-axis-column-${layerId}`,
Expand All @@ -630,7 +630,7 @@ export class LensAttributes {
filter: { query: columnFilter, language: 'kuery' },
...(timeShift ? { timeShift } : {}),
},
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN && breakdown !== 'percentile'
...(breakdown && sourceField !== USE_BREAK_DOWN_COLUMN && breakdown !== PERCENTILE
? // do nothing since this will be used a x axis source
{
[`breakdown-column-${layerId}`]: this.getBreakdownColumn({
Expand Down

0 comments on commit 5620f14

Please sign in to comment.