Skip to content

Commit

Permalink
Addressing feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-buttner committed Nov 14, 2022
1 parent b51f3f5 commit 5425543
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ describe('Execution Handler', () => {
`);
});

it('does not populate the rule.url when the alert id is set to undefined', async () => {
it('does not populate the rule.url when the rule id is set to undefined', async () => {
const execParams = {
...defaultExecutionParams,
rule: ruleWithUrl,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,9 @@ export class ExecutionHandler<

return ruleUrl.toString();
} catch (error) {
this.logger.debug(
`Rule "${this.rule.id}" encountered an error while constructing the rule.url variable: ${error.message}`
);
return;
}
}
Expand Down

0 comments on commit 5425543

Please sign in to comment.