Stability fixes

elastic · Nov 26, 2019 · 53be053 · 53be053
1 parent 30fe0c1
commit 53be053
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 16 deletions.
diff --git a/x-pack/test/functional/services/machine_learning/job_management.ts b/x-pack/test/functional/services/machine_learning/job_management.ts
@@ -36,10 +36,7 @@ export function MachineLearningJobManagementProvider(
     },
 
     async assertStartDatafeedModalExists() {
-      // this retry can be removed as soon as #48734 is merged
-      await retry.tryForTime(5000, async () => {
-        await testSubjects.existOrFail('mlStartDatafeedModal');
-      });
+      await testSubjects.existOrFail('mlStartDatafeedModal', { timeout: 5000 });
     },
 
     async confirmStartDatafeedModal() {

diff --git a/x-pack/test/functional/services/machine_learning/job_wizard_advanced.ts b/x-pack/test/functional/services/machine_learning/job_wizard_advanced.ts
@@ -146,10 +146,7 @@ export function MachineLearningJobWizardAdvancedProvider({
     },
 
     async assertCreateDetectorModalExists() {
-      // this retry can be removed as soon as #48734 is merged
-      await retry.tryForTime(5000, async () => {
-        await testSubjects.existOrFail('mlCreateDetectorModal');
-      });
+      await testSubjects.existOrFail('mlCreateDetectorModal', { timeout: 5000 });
     },
 
     async assertDetectorFunctionInputExists() {
@@ -298,18 +295,17 @@ export function MachineLearningJobWizardAdvancedProvider({
     },
 
     async clickEditDetector(detectorIndex: number) {
-      await testSubjects.click(
-        `mlAdvancedDetector ${detectorIndex} > mlAdvancedDetectorEditButton`
-      );
-      await this.assertCreateDetectorModalExists();
+      retry.tryForTime(20 * 1000, async () => {
+        await testSubjects.click(
+          `mlAdvancedDetector ${detectorIndex} > mlAdvancedDetectorEditButton`
+        );
+        await this.assertCreateDetectorModalExists();
+      });
     },
 
     async createJob() {
       await testSubjects.clickWhenNotDisabled('mlJobWizardButtonCreateJob');
-      // this retry can be removed as soon as #48734 is merged
-      await retry.tryForTime(5000, async () => {
-        await testSubjects.existOrFail('mlStartDatafeedModal');
-      });
+      await testSubjects.existOrFail('mlStartDatafeedModal', { timeout: 10 * 1000 });
     },
   };
 }