Record transaction duration alerts in microseconds (#112366)

elastic · Sep 16, 2021 · 506cfcf · 506cfcf
1 parent 9eb74be
commit 506cfcf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_alert_type.test.ts b/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_alert_type.test.ts
@@ -59,7 +59,7 @@ describe('registerTransactionDurationAlertType', () => {
       transactionType: 'request',
       serviceName: 'opbeans-java',
       environment: 'Not defined',
-      threshold: 3000,
+      threshold: 3000000,
       triggerValue: '5,500 ms',
       interval: `5m`,
     });

diff --git a/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_alert_type.ts b/x-pack/plugins/apm/server/lib/alerts/register_transaction_duration_alert_type.ts
@@ -201,11 +201,11 @@ export function registerTransactionDurationAlertType({
               [TRANSACTION_TYPE]: alertParams.transactionType,
               [PROCESSOR_EVENT]: ProcessorEvent.transaction,
               [ALERT_EVALUATION_VALUE]: transactionDuration,
-              [ALERT_EVALUATION_THRESHOLD]: alertParams.threshold,
+              [ALERT_EVALUATION_THRESHOLD]: thresholdMicroseconds,
               [ALERT_REASON]: formatTransactionDurationReason({
                 measured: transactionDuration,
                 serviceName: alertParams.serviceName,
-                threshold: alertParams.threshold,
+                threshold: thresholdMicroseconds,
                 asDuration,
               }),
             },
@@ -214,7 +214,7 @@ export function registerTransactionDurationAlertType({
             transactionType: alertParams.transactionType,
             serviceName: alertParams.serviceName,
             environment: getEnvironmentLabel(alertParams.environment),
-            threshold: alertParams.threshold,
+            threshold: thresholdMicroseconds,
             triggerValue: transactionDurationFormatted,
             interval: `${alertParams.windowSize}${alertParams.windowUnit}`,
           });