-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change usage stats check for first-party request headers
First implementation made a best-effort attempt to determine whether or not a request was "first-party" (from the Kibana client) by checking "kbn-version", "origin", and "referer". If these three headers are all present, we thought it was very likely that the request was first-party. However, further testing after adding usage stats collection for additional SO APIs determined this to be inaccurate; some actual first-party requests do not include the "origin" header. I am not sure exactly why this is the case, but I have changed the check to use "user-agent" instead. This is another indicator that a request likely did not come from a programmatic consumer.
- Loading branch information
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters