[Lens] Fixes partition legend visibility (#130090) (#130169)

(cherry picked from commit 405a9cf) Co-authored-by: Stratoula Kalafateli <[email protected]>
elastic · Apr 13, 2022 · 4cae03e · 4cae03e
1 parent bb00a98
commit 4cae03e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/.../chart_expressions/expression_partition_vis/public/components/partition_vis_component.tsx b/.../chart_expressions/expression_partition_vis/public/components/partition_vis_component.tsx
@@ -126,12 +126,8 @@ const PartitionVisComponent = (props: PartitionVisComponentProps) => {
 
   useEffect(() => {
     const legendShow = showLegendDefault();
-    const showLegendDef = shouldShowLegend(visType, visParams.legendDisplay, bucketColumns);
-    if (showLegendDef !== legendShow) {
-      setShowLegend(legendShow);
-      props.uiState?.set('vis.legendOpen', legendShow);
-    }
-  }, [showLegendDefault, props.uiState, visParams.legendDisplay, visType, bucketColumns]);
+    setShowLegend(legendShow);
+  }, [showLegendDefault]);
 
   const onRenderChange = useCallback<RenderChangeListener>(
     (isRendered) => {

diff --git a/src/plugins/vis_types/pie/public/editor/components/pie.tsx b/src/plugins/vis_types/pie/public/editor/components/pie.tsx
@@ -104,8 +104,8 @@ const PieOptions = (props: PieOptionsProps) => {
   );
 
   useEffect(() => {
-    setLegendVisibility(legendUiStateValue);
-  }, [legendUiStateValue]);
+    setLegendVisibility(legendUiStateValue ?? stateParams.legendDisplay === LegendDisplay.SHOW);
+  }, [legendUiStateValue, stateParams.legendDisplay]);
 
   useEffect(() => {
     const fetchPalettes = async () => {