-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Detection engine] skips geo_point non-ecs validat…
…ion (#163487) ## Summary While reviewing #163414, I have noticed, that `geo_point` type still gets validated in `computeIsEcsCompliant`, that could lead to removing some of the complex `geo_point` type representations, notably object like ones, for example ```JSON { "type": "Point", "coordinates": [-88.34, 20.12], } ``` In this PR, I completely removing validation for this field type (we even have functional test to verify it) With changes introduced in #163414, alert will be created even with not valid `geo_point` fields, instead of failing (changed e2e test name) ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
Showing
3 changed files
with
77 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters