[ML] Fix data-test-subj.

elastic · Oct 1, 2020 · 486511a · 486511a
1 parent 819cf7d
commit 486511a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/...nalytics/pages/analytics_exploration/components/expandable_section/expandable_section.tsx b/...nalytics/pages/analytics_exploration/components/expandable_section/expandable_section.tsx
@@ -33,6 +33,7 @@ export interface ExpandableSectionProps {
   content: ReactNode;
   headerItems?: HeaderItem[] | 'loading';
   isExpanded?: boolean;
+  dataTestId: string;
   title: ReactNode;
 }
 
@@ -44,6 +45,7 @@ export const ExpandableSection: FC<ExpandableSectionProps> = ({
   // callback.
   isExpanded: isExpandedDefault = true,
   content,
+  dataTestId,
   title,
 }) => {
   const [isExpanded, setIsExpanded] = useState(isExpandedDefault);
@@ -52,7 +54,7 @@ export const ExpandableSection: FC<ExpandableSectionProps> = ({
   };
 
   return (
-    <EuiPanel paddingSize="none" data-test-subj="mlDFAnalyticsOutlierExplorationTablePanel">
+    <EuiPanel paddingSize="none" data-test-subj={`mlDFExpandableSection-${dataTestId}`}>
       <div className="mlExpandableSection">
         <EuiButtonEmpty
           onClick={toggleExpanded}
@@ -67,7 +69,11 @@ export const ExpandableSection: FC<ExpandableSectionProps> = ({
         {isHeaderItems(headerItems) && (
           <EuiFlexGroup>
             {headerItems.map(({ label, value, id }) => (
-              <EuiFlexItem grow={false} key={id}>
+              <EuiFlexItem
+                grow={false}
+                key={id}
+                data-test-subj={`mlDFExpandableSectionItem-${dataTestId}-${id}`}
+              >
                 {label !== undefined && value !== undefined && (
                   <>
                     <EuiText size="xs" color="subdued">

diff --git a/...lytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx b/...lytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx
@@ -235,6 +235,7 @@ export const OutlierExploration: FC<ExplorationProps> = React.memo(({ jobId }) =
         )}
 
       <ExpandableSection
+        dataTestId="analysis"
         content={analyticsSectionContent}
         headerItems={analyticsSectionHeaderItems}
         isExpanded={false}
@@ -249,6 +250,7 @@ export const OutlierExploration: FC<ExplorationProps> = React.memo(({ jobId }) =
       <EuiSpacer size="m" />
 
       <ExpandableSection
+        dataTestId="results"
         content={resultsSectionContent}
         headerItems={resultsSectionHeaderItems}
         title={

diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_results.ts b/x-pack/test/functional/services/ml/data_frame_analytics_results.ts
@@ -36,7 +36,7 @@ export function MachineLearningDataFrameAnalyticsResultsProvider({
     },
 
     async assertOutlierTablePanelExists() {
-      await testSubjects.existOrFail('mlDFAnalyticsOutlierExplorationTablePanel');
+      await testSubjects.existOrFail('mlDFExpandableSection-results');
     },
 
     async assertResultsTableExists() {