Code review fixes

elastic · Jan 29, 2020 · 47b7bef · 47b7bef
1 parent 7279243
commit 47b7bef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/kbn-plugin-generator/sao_template/template/public/components/app.tsx b/packages/kbn-plugin-generator/sao_template/template/public/components/app.tsx
@@ -35,7 +35,7 @@ import {
   EuiText,
 } from '@elastic/eui';
 
-import { AppMountParameters, CoreStart } from '<%= relRoot %>/../src/core/public';
+import { CoreStart } from '<%= relRoot %>/../src/core/public';
 import { NavigationPublicPluginStart } from '<%= relRoot %>/../src/plugins/navigation/public';
 
 import { PLUGIN_ID, PLUGIN_NAME } from '../../common';
@@ -103,13 +103,13 @@ export const <%= upperCamelCaseName %>App = ({ basename, notifications, http, na
                     <p>
                       <FormattedMessage
                         id="<%= camelCase(name) %>.content"
-                        defaultMessage="Look through the generated code and checkout the plugin developmment documentation."
+                        defaultMessage="Look through the generated code and checkout the plugin development documentation."
                       />
                     </p>
                     <EuiHorizontalRule/>
                     <p>
                       <FormattedMessage
-                        id="banana.timestampText"
+                        id="<%= camelCase(name) %>.timestampText"
                         defaultMessage="Last timestamp: {time}"
                         values={{ time: timestamp ? timestamp : 'Unknown' }}
                       />

diff --git a/packages/kbn-plugin-generator/sao_template/template/public/plugin.ts b/packages/kbn-plugin-generator/sao_template/template/public/plugin.ts
@@ -1,5 +1,5 @@
 import { i18n } from '@kbn/i18n';
-import { CoreSetup, CoreStart, Plugin } from '<%= relRoot %>/src/core/public';
+import { AppMountParameters, CoreSetup, CoreStart, Plugin } from '<%= relRoot %>/src/core/public';
 import { <%= upperCamelCaseName %>PublicPluginSetup, <%= upperCamelCaseName %>PublicPluginStart, AppPluginDependencies } from './types';
 import { PLUGIN_NAME } from '../common';
 
@@ -11,7 +11,7 @@ export class <%= upperCamelCaseName %>PublicPlugin
     core.application.register({
       id: '<%= camelCase(name) %>',
       title: PLUGIN_NAME,
-      async mount(params) {
+      async mount(params: AppMountParameters) {
         // Load application bundle
         const { renderApp } = await import('./application');
         // Get start services as specified in kibana.json