[APM] Fix deduplication for focused service maps (#61580)

Closes #61292. Co-authored-by: Elastic Machine <[email protected]>
elastic · Mar 28, 2020 · 47184fb · 47184fb
1 parent 808dc85
commit 47184fb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/x-pack/plugins/apm/server/lib/service_map/dedupe_connections/index.test.ts b/x-pack/plugins/apm/server/lib/service_map/dedupe_connections/index.test.ts
@@ -140,4 +140,21 @@ describe('dedupeConnections', () => {
     // @ts-ignore
     expect(nodejsNode?.data[SPAN_SUBTYPE]).toBe('aa');
   });
+
+  it('processes connections without a matching "service" aggregation', () => {
+    const response: ServiceMapResponse = {
+      services: [javaService],
+      discoveredServices: [],
+      connections: [
+        {
+          source: javaService,
+          destination: nodejsService
+        }
+      ]
+    };
+
+    const { elements } = dedupeConnections(response);
+
+    expect(elements.length).toBe(3);
+  });
 });
diff --git a/x-pack/plugins/apm/server/lib/service_map/dedupe_connections/index.ts b/x-pack/plugins/apm/server/lib/service_map/dedupe_connections/index.ts
@@ -88,7 +88,7 @@ export function dedupeConnections(response: ServiceMapResponse) {
       serviceName = node[SERVICE_NAME];
     }
 
-    const matchedServiceNodes = services.filter(
+    const matchedServiceNodes = serviceNodes.filter(
       serviceNode => serviceNode[SERVICE_NAME] === serviceName
     );