delete through library in functional tests

elastic · Jun 12, 2023 · 4259be3 · 4259be3
1 parent d87ebb5
commit 4259be3
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 10 deletions.
diff --git a/test/functional/page_objects/visualize_page.ts b/test/functional/page_objects/visualize_page.ts
@@ -69,6 +69,14 @@ export class VisualizePageObject extends FtrService {
     await this.common.navigateToApp('visualize');
   }
 
+  public async selectVisualizationsTab() {
+    await this.listingTable.selectTab(1);
+  }
+
+  public async selectAnnotationsTab() {
+    await this.listingTable.selectTab(2);
+  }
+
   public async clickNewVisualization() {
     await this.listingTable.clickNewButton();
   }

diff --git a/test/functional/services/listing_table.ts b/test/functional/services/listing_table.ts
@@ -204,6 +204,10 @@ export class ListingTableService extends FtrService {
     await this.testSubjects.click('deleteSelectedItems');
   }
 
+  public async selectFirstItemInList() {
+    await this.find.clickByCssSelector('.euiTableCellContent .euiCheckbox__input');
+  }
+
   public async clickItemCheckbox(id: string) {
     await this.testSubjects.click(`checkboxSelectRow-${id}`);
   }
@@ -213,9 +217,13 @@ export class ListingTableService extends FtrService {
    * @param name item name
    * @param id row id
    */
-  public async deleteItem(name: string, id: string) {
+  public async deleteItem(name: string, id?: string) {
     await this.searchForItemWithName(name);
-    await this.clickItemCheckbox(id);
+    if (id) {
+      await this.clickItemCheckbox(id);
+    } else {
+      await this.selectFirstItemInList();
+    }
     await this.clickDeleteSelected();
     await this.common.clickConfirmOnModal();
   }
@@ -253,4 +261,8 @@ export class ListingTableService extends FtrService {
       timeout: 5000,
     });
   }
+
+  public async selectTab(which: number) {
+    await this.find.clickByCssSelector(`.euiTab:nth-child(${which})`);
+  }
 }
diff --git a/x-pack/test/functional/apps/lens/group6/annotations.ts b/x-pack/test/functional/apps/lens/group6/annotations.ts
@@ -22,6 +22,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const retry = getService('retry');
   const toastsService = getService('toasts');
   const testSubjects = getService('testSubjects');
+  const listingTable = getService('listingTable');
   const from = 'Sep 19, 2015 @ 06:31:44.000';
   const to = 'Sep 23, 2015 @ 18:31:44.000';
 
@@ -181,15 +182,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
 
       it('should remove layer for deleted annotation group', async () => {
-        // TODO - delete from listing page instead
-
-        await PageObjects.settings.navigateTo();
-        await PageObjects.settings.clickKibanaSavedObjects();
-        await PageObjects.savedObjects.searchForObject(ANNOTATION_GROUP_TITLE);
-        await PageObjects.savedObjects.clickCheckboxByTitle(ANNOTATION_GROUP_TITLE);
-        await PageObjects.savedObjects.clickDelete({ confirmDelete: true });
-
         await PageObjects.visualize.gotoVisualizationLandingPage();
+        await PageObjects.visualize.selectAnnotationsTab();
+        await listingTable.deleteItem(ANNOTATION_GROUP_TITLE);
+        await PageObjects.visualize.selectVisualizationsTab();
         await PageObjects.visualize.loadSavedVisualization(FIRST_VIS_TITLE, {
           navigateToVisualize: false,
         });