[Maps] fix term join not updating when editing right field

elastic · Sep 2, 2021 · 3fe851b · 3fe851b
1 parent f21731f
commit 3fe851b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.test.js b/x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.test.js
@@ -109,3 +109,20 @@ describe('extractPropertiesMap', () => {
     expect(properties[minPropName]).toBe(0);
   });
 });
+
+describe('getSyncMeta', () => {
+  it('should contain meta requiring source re-fetch when changed', () => {
+    const source = new ESTermSource({
+      id: '1234',
+      indexPatternTitle: indexPatternTitle,
+      term: termFieldName,
+      indexPatternId: 'foobar',
+      size: 10,
+    });
+    expect(source.getSyncMeta()).toEqual({
+      indexPatternId: 'foobar',
+      size: 10,
+      term: 'myTermField',
+    });
+  });
+});
diff --git a/x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.ts b/x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.ts
@@ -172,11 +172,11 @@ export class ESTermSource extends AbstractESAggSource implements ITermJoinSource
   }
 
   getSyncMeta(): VectorSourceSyncMeta | null {
-    return this._descriptor.size !== undefined
-      ? {
-          size: this._descriptor.size,
-        }
-      : null;
+    return {
+      indexPatternId: this._descriptor.indexPatternId,
+      term: this._descriptor.term,
+      size: this._descriptor.size,
+    };
   }
 
   getRightFields(): IField[] {