Skip to content

Commit

Permalink
Update FT
Browse files Browse the repository at this point in the history
  • Loading branch information
stratoula committed Sep 27, 2024
1 parent 527bf1b commit 3fb5319
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions test/functional/apps/discover/group3/_lens_vis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,23 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await discover.getHitCount()).to.be(totalCount);
}

async function checkESQLHistogramVis(timespan: string, totalCount: string) {
async function checkESQLHistogramVis(
timespan: string,
totalCount: string,
hasTransformationalCommand = false
) {
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();

await testSubjects.existOrFail('xyVisChart');
await testSubjects.existOrFail('unifiedHistogramSaveVisualization');
await testSubjects.existOrFail('unifiedHistogramEditFlyoutVisualization');
await testSubjects.missingOrFail('unifiedHistogramEditVisualization');
await testSubjects.missingOrFail('unifiedHistogramBreakdownSelectorButton');
if (hasTransformationalCommand) {
await testSubjects.missingOrFail('unifiedHistogramBreakdownSelectorButton');
} else {
await testSubjects.existOrFail('unifiedHistogramBreakdownSelectorButton');
}
await testSubjects.missingOrFail('unifiedHistogramTimeIntervalSelectorButton');
expect(await discover.getChartTimespan()).to.be(timespan);
expect(await discover.getHitCount()).to.be(totalCount);
Expand Down Expand Up @@ -102,7 +110,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
return seriesType;
}

describe('discover lens vis', function () {
describe('discover lens vis-meow', function () {
before(async () => {
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
Expand Down Expand Up @@ -309,7 +317,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();

await checkESQLHistogramVis(defaultTimespanESQL, '5');
await checkESQLHistogramVis(defaultTimespanESQL, '5', true);
await discover.chooseLensSuggestion('pie');

await testSubjects.existOrFail('unsavedChangesBadge');
Expand Down Expand Up @@ -358,7 +366,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();

await checkESQLHistogramVis(defaultTimespanESQL, '5');
await checkESQLHistogramVis(defaultTimespanESQL, '5', true);
await discover.chooseLensSuggestion('pie');

await testSubjects.existOrFail('unsavedChangesBadge');
Expand Down Expand Up @@ -411,7 +419,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();

await checkESQLHistogramVis(defaultTimespanESQL, '5');
await checkESQLHistogramVis(defaultTimespanESQL, '5', true);
await discover.chooseLensSuggestion('pie');

await testSubjects.existOrFail('unsavedChangesBadge');
Expand Down Expand Up @@ -455,7 +463,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await header.waitUntilLoadingHasFinished();
await discover.waitUntilSearchingHasFinished();

await checkESQLHistogramVis(defaultTimespanESQL, '5');
await checkESQLHistogramVis(defaultTimespanESQL, '5', true);
await discover.chooseLensSuggestion('pie');

await discover.saveSearch('testCustomESQLVis');
Expand Down

0 comments on commit 3fb5319

Please sign in to comment.