Updated types for DraggableStateSnapshot in 2 files.

elastic · Aug 10, 2023 · 3f3e0bb · 3f3e0bb
1 parent d8d1a41
commit 3f3e0bb
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/...ck/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.tsx b/...ck/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.tsx
@@ -355,13 +355,31 @@ const DraggableWrapperComponent: React.FC<Props> = ({
       >
         {truncate ? (
           <TruncatableText data-test-subj="render-truncatable-content">
-            {render(dataProvider, null, { isDragging: false, isDropAnimating: false })}
+            {render(dataProvider, null, {
+              isDragging: false,
+              isDropAnimating: false,
+              isClone: false,
+              dropAnimation: null,
+              draggingOver: null,
+              combineWith: null,
+              combineTargetFor: null,
+              mode: null,
+            })}
           </TruncatableText>
         ) : (
           <ProviderContentWrapper
             data-test-subj={`render-content-${dataProvider.queryMatch.field}`}
           >
-            {render(dataProvider, null, { isDragging: false, isDropAnimating: false })}
+            {render(dataProvider, null, {
+              isDragging: false,
+              isDropAnimating: false,
+              isClone: false,
+              dropAnimation: null,
+              draggingOver: null,
+              combineWith: null,
+              combineTargetFor: null,
+              mode: null,
+            })}
           </ProviderContentWrapper>
         )}
       </div>

diff --git a/...ns/security_solution/public/timelines/components/timeline/data_providers/helpers.test.tsx b/...ns/security_solution/public/timelines/components/timeline/data_providers/helpers.test.tsx
@@ -181,8 +181,8 @@ describe('helpers', () => {
   });
 
   describe('isValidDestination', () => {
-    test('it returns false when destination is undefined', () => {
-      expect(isValidDestination(undefined)).toBe(false);
+    test('it returns false when destination is null', () => {
+      expect(isValidDestination(null)).toBe(false);
     });
 
     test('it returns true when the type guard matches as DraggableLocation ', () => {
@@ -861,7 +861,7 @@ describe('helpers', () => {
 
       addProviderToGroup({
         dataProviders,
-        destination: undefined,
+        destination: null,
         dispatch,
         onAddedToTimeline,
         providerToAdd,
@@ -877,7 +877,7 @@ describe('helpers', () => {
 
       addProviderToGroup({
         dataProviders,
-        destination: undefined,
+        destination: null,
         dispatch,
         onAddedToTimeline,
         providerToAdd,