Add custom serializer to overwrite the default one from the shared field

elastic · May 11, 2021 · 3e25668 · 3e25668
1 parent 0522a5c
commit 3e25668
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/...lic/application/components/pipeline_editor/__jest__/processors/registered_domain.test.tsx b/...lic/application/components/pipeline_editor/__jest__/processors/registered_domain.test.tsx
@@ -12,7 +12,7 @@ import { setup, SetupResult, getProcessorValue } from './processor.helpers';
 const defaultRegisteredDomainParameters = {
   description: undefined,
   if: undefined,
-  ignore_missing: true,
+  ignore_missing: undefined,
   ignore_failure: undefined,
 };
 
@@ -82,6 +82,29 @@ describe('Processor: Registered Domain', () => {
     });
   });
 
+  test('should still send ignore_missing:false when the toggle is disabled', async () => {
+    const {
+      actions: { saveNewProcessor },
+      form,
+    } = testBed;
+
+    // Add "field" value (required)
+    form.setInputValue('fieldNameField.input', 'field_1');
+
+    // Disable ignore missing toggle
+    form.toggleEuiSwitch('ignoreMissingSwitch.input');
+
+    // Save the field with new changes
+    await saveNewProcessor();
+
+    const processors = getProcessorValue(onUpdate, REGISTERED_DOMAIN_TYPE);
+    expect(processors[0][REGISTERED_DOMAIN_TYPE]).toEqual({
+      ...defaultRegisteredDomainParameters,
+      field: 'field_1',
+      ignore_missing: false,
+    });
+  });
+
   test('allows optional parameters to be set', async () => {
     const {
       actions: { saveNewProcessor },

diff --git a/...peline_editor/components/processor_form/processors/common_fields/ignore_missing_field.tsx b/...peline_editor/components/processor_form/processors/common_fields/ignore_missing_field.tsx
@@ -43,7 +43,7 @@ export const fieldsConfig: FieldsConfig = {
   },
 };
 
-type Props = Partial<FieldConfig>;
+type Props = Partial<FieldConfig<any>>;
 
 export const IgnoreMissingField: FunctionComponent<Props> = (props) => (
   <UseField

diff --git a/...ion/components/pipeline_editor/components/processor_form/processors/registered_domain.tsx b/...ion/components/pipeline_editor/components/processor_form/processors/registered_domain.tsx
@@ -11,6 +11,7 @@ import { i18n } from '@kbn/i18n';
 import { FieldNameField } from './common_fields/field_name_field';
 import { TargetField } from './common_fields/target_field';
 import { IgnoreMissingField } from './common_fields/ignore_missing_field';
+import { from } from './shared';
 
 export const RegisteredDomain: FunctionComponent = () => {
   return (
@@ -24,7 +25,7 @@ export const RegisteredDomain: FunctionComponent = () => {
 
       <TargetField />
 
-      <IgnoreMissingField defaultValue={true} />
+      <IgnoreMissingField defaultValue={true} serializer={from.undefinedIfValue(true)} />
     </>
   );
 };