Remove unused code and fix defaultValue

elastic · Jul 20, 2022 · 38be325 · 38be325
1 parent b785fc9
commit 38be325
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/...k/plugins/security_solution/public/detections/components/rules/step_define_rule/index.tsx b/...k/plugins/security_solution/public/detections/components/rules/step_define_rule/index.tsx
@@ -191,10 +191,7 @@ const StepDefineRuleComponent: FC<StepDefineRuleProps> = ({
     index: indicesConfig,
     threatIndex: threatIndicesConfig,
   };
-  initialState.dataSourceType =
-    initialState.dataViewId == null || initialState.dataViewId === ''
-      ? DataSourceType.IndexPatterns
-      : DataSourceType.DataView;
+
 
   const { form } = useForm<DefineStepRule>({
     defaultValue: initialState,

diff --git a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.tsx b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.tsx
@@ -120,8 +120,7 @@ export const getDefineStepsData = (rule: Rule): DefineStepRule => ({
     eventCategoryField: rule.event_category_override,
     tiebreakerField: rule.tiebreaker_field,
   },
-  // defaulting this since it is set in the component anyways.
-  dataSourceType: DataSourceType.IndexPatterns,
+  dataSourceType: rule.data_view_id ? DataSourceType.DataView : DataSourceType.IndexPatterns,
 });
 
 export const getScheduleStepsData = (rule: Rule): ScheduleStepRule => {