properly set test-subj attribute

elastic · Oct 11, 2021 · 389b510 · 389b510
1 parent 930fe96
commit 389b510
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/x-pack/plugins/monitoring/public/application/pages/kibana/instance.tsx b/x-pack/plugins/monitoring/public/application/pages/kibana/instance.tsx
@@ -149,13 +149,8 @@ export const KibanaInstancePage: React.FC<ComponentProps> = ({ clusters }) => {
   }, [ccs, clusterUuid, instance, services.data?.query.timefilter.timefilter, services.http]);
 
   return (
-    <PageTemplate
-      title={title}
-      pageTitle={pageTitle}
-      getPageData={getPageData}
-      data-test-subj="kibanaInstancePage"
-    >
-      <div data-test-subj="monitoringKibanaInstanceApp">
+    <PageTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
+      <div data-test-subj="kibanaInstancePage">
         <KibanaInstance data={data} alerts={{}} />
       </div>
     </PageTemplate>

diff --git a/x-pack/plugins/monitoring/public/application/pages/kibana/instances.tsx b/x-pack/plugins/monitoring/public/application/pages/kibana/instances.tsx
@@ -72,12 +72,7 @@ export const KibanaInstancesPage: React.FC<ComponentProps> = ({ clusters }) => {
   ]);
 
   return (
-    <KibanaTemplate
-      title={title}
-      pageTitle={pageTitle}
-      getPageData={getPageData}
-      data-test-subj="kibanaInstancesPage"
-    >
+    <KibanaTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
       <div data-test-subj="monitoringKibanaInstancesApp">
         <SetupModeRenderer
           productName={KIBANA_SYSTEM_ID}

diff --git a/x-pack/plugins/monitoring/public/application/pages/kibana/kibana_template.tsx b/x-pack/plugins/monitoring/public/application/pages/kibana/kibana_template.tsx
@@ -16,13 +16,15 @@ export const KibanaTemplate: React.FC<PageTemplateProps> = ({ ...props }) => {
         defaultMessage: 'Overview',
       }),
       route: '/kibana',
+      testSubj: 'kibanaOverviewPage',
     },
     {
       id: 'instances',
       label: i18n.translate('xpack.monitoring.kibanaNavigation.instancesLinkText', {
         defaultMessage: 'Instances',
       }),
       route: '/kibana/instances',
+      testSubj: 'kibanaInstancesPage',
     },
   ];
 

diff --git a/x-pack/plugins/monitoring/public/application/pages/kibana/overview.tsx b/x-pack/plugins/monitoring/public/application/pages/kibana/overview.tsx
@@ -108,7 +108,6 @@ export const KibanaOverviewPage: React.FC<ComponentProps> = ({ clusters }) => {
 
   return (
     <KibanaTemplate
-      data-test-subj="kibanaOverviewPage"
       getPageData={getPageData}
       title={title}
       pageTitle={pageTitle}