[eslint] require final newline (#32265)

We have had `insert_final_newline = true` in our `.editorconfig` file since April 2015, but never validated it with eslint. I'm a little tired of extra changes showing up in PRs because some people use editors which respect the `.editorconfig` file and some don't, so I figured we might want to enable the rule in eslint so that the can be autofixed.

Votes requested please :)

packages/eslint-config-kibana/.eslintrc.js

@@ -100,6 +100,7 @@ module.exports = {
     strict: [ 'error', 'never' ],
     'valid-typeof': 'error',
     'wrap-iife': [ 'error', 'outside' ],
+    'eol-last': ['error', 'always'],
     yoda: 'off',
 
     'object-curly-spacing': 'off', // overridden with babel/object-curly-spacing
@@ -150,7 +151,7 @@ module.exports = {
     'jsx-a11y/role-supports-aria-props': 'error',
     'jsx-a11y/scope': 'error',
     'jsx-a11y/tabindex-no-positive': 'error',
-    'jsx-a11y/label-has-associated-control': 'error',  
+    'jsx-a11y/label-has-associated-control': 'error',
     'react/jsx-equals-spacing': ['error', 'never'],
     'react/jsx-indent': ['error', 2],
     'react/no-will-update-set-state': 'error',

src/fixtures/field_mapping.js

@@ -76,4 +76,4 @@ export default {
       }
     }
   }
-};
+};

src/fixtures/mapping_with_dupes.js

@@ -54,4 +54,4 @@ export default {
       }
     }
   }
-};
+};

src/fixtures/search_response.js

@@ -32,4 +32,4 @@ export default {
     max_score: 1.0,
     hits: hits
   }
-};
+};

src/legacy/core_plugins/console/api_server/es_6_0/query/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export { queryDsl as default }  from './dsl';
+export { queryDsl as default }  from './dsl';

src/legacy/core_plugins/console/api_server/es_6_0/reindex.js

@@ -65,4 +65,4 @@ export default function (api) {
       'script': { __scope_link: 'GLOBAL.script' },
     }
   });
-}
+}

src/legacy/core_plugins/console/api_server/spec/index.js

@@ -56,4 +56,4 @@ export function getSpec() {
 
 export function addExtensionSpecFilePath(extensionSpecFilePath) {
   extensionSpecFilePaths.push(extensionSpecFilePath);
-}
+}

src/legacy/core_plugins/console/public/src/autocomplete/components/conditional_proxy.js

@@ -40,4 +40,4 @@ export class ConditionalProxy extends SharedComponent {
       return false;
     }
   }
-}
+}

src/legacy/core_plugins/console/public/src/autocomplete/components/global_only_component.js

@@ -43,4 +43,4 @@ export class GlobalOnlyComponent extends SharedComponent {
     return result;
 
   }
-}
+}

src/legacy/core_plugins/console/public/src/autocomplete/components/index_autocomplete_component.js

@@ -40,4 +40,4 @@ export class IndexAutocompleteComponent extends ListComponent {
   getContextKey() {
     return 'indices';
   }
-}
+}

src/legacy/core_plugins/console/public/src/autocomplete/components/template_autocomplete_component.js

@@ -26,4 +26,4 @@ export class TemplateAutocompleteComponent extends ListComponent {
   getContextKey() {
     return 'template';
   }
-}
+}

src/legacy/core_plugins/console/public/src/autocomplete/components/username_autocomplete_component.js

@@ -40,4 +40,4 @@ export class UsernameAutocompleteComponent extends ListComponent {
   getContextKey() {
     return 'username';
   }
-}
+}

src/legacy/core_plugins/console/public/src/sense_editor/mode/script_highlight_rules.js

@@ -82,4 +82,4 @@ export function ScriptHighlightRules() {
   };
 }
 
-oop.inherits(ScriptHighlightRules, TextHighlightRules);
+oop.inherits(ScriptHighlightRules, TextHighlightRules);

src/legacy/core_plugins/console/public/src/sense_editor/mode/worker/index.js

@@ -20,4 +20,4 @@
 export const workerModule = {
   id: 'sense_editor/mode/worker',
   src: require('!!raw-loader!./worker.js')
-};
+};

src/legacy/core_plugins/kibana/public/management/sections/index_patterns/index_pattern_table/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export { IndexPatternTable } from './index_pattern_table';
+export { IndexPatternTable } from './index_pattern_table';

src/legacy/core_plugins/kibana/public/management/sections/settings/components/component_registry.js

@@ -70,4 +70,4 @@ export function getSettingsComponent(id) {
     throw new Error(`Component not found with id ${id}`);
   }
   return registry[id];
-}
+}

src/legacy/core_plugins/kibana/public/management/sections/settings/components/component_registry.test.js

@@ -86,4 +86,4 @@ describe('getSettingsComponent', () => {
   it('should throw an error when requesting a component that does not exist', () => {
     expect(() => getSettingsComponent('does not exist')).toThrowErrorMatchingSnapshot();
   });
-});
+});

src/legacy/core_plugins/kibana/public/management/sections/settings/components/default_component_registry.js

@@ -30,4 +30,4 @@ export function registerDefaultComponents() {
   tryRegisterSettingsComponent(PAGE_TITLE_COMPONENT, PageTitle);
   tryRegisterSettingsComponent(PAGE_SUBTITLE_COMPONENT, PageSubtitle);
   tryRegisterSettingsComponent(PAGE_FOOTER_COMPONENT, PageFooter);
-}
+}

src/legacy/core_plugins/kibana/public/management/sections/settings/components/default_component_registry.test.js

@@ -40,4 +40,4 @@ describe('default_component_registry', () => {
 
     expect(getSettingsComponent(PAGE_TITLE_COMPONENT)).toEqual(newComponent);
   });
-});
+});

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_footer/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export { PageFooter } from './page_footer';
+export { PageFooter } from './page_footer';

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_footer/page_footer.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export const PageFooter = () => null;
+export const PageFooter = () => null;

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_footer/page_footer.test.js

@@ -25,4 +25,4 @@ describe('PageFooter', () => {
   it('should render normally', () => {
     expect(shallowWithIntl(<PageFooter />)).toMatchSnapshot();
   });
-});
+});

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_subtitle/page_subtitle.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export const PageSubtitle = () => null;
+export const PageSubtitle = () => null;

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_subtitle/page_subtitle.test.js

@@ -25,4 +25,4 @@ describe('PageSubtitle', () => {
   it('should render normally', () => {
     expect(shallowWithIntl(<PageSubtitle />)).toMatchSnapshot();
   });
-});
+});

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_title/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export { PageTitle } from './page_title';
+export { PageTitle } from './page_title';

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_title/page_title.js

@@ -34,4 +34,4 @@ export const PageTitle = () => {
       </h1>
     </EuiText>
   );
-};
+};

src/legacy/core_plugins/kibana/public/management/sections/settings/components/page_title/page_title.test.js

@@ -25,4 +25,4 @@ describe('PageTitle', () => {
   it('should render normally', () => {
     expect(shallowWithIntl(<PageTitle />)).toMatchSnapshot();
   });
-});
+});

src/legacy/core_plugins/metrics/public/components/lib/create_number_handler.js

@@ -28,4 +28,4 @@ export default (handleChange) => {
       return handleChange({ [name]: value });
     }
   };
-};
+};

src/legacy/core_plugins/metrics/public/components/lib/create_text_handler.js

@@ -30,4 +30,4 @@ export default (handleChange) => {
       return handleChange({ [name]: value });
     }
   };
-};
+};

src/legacy/core_plugins/metrics/public/components/lib/detect_ie.js

@@ -41,4 +41,4 @@ export function detectIE() {
 
   // other browser
   return false;
-}
+}

src/legacy/core_plugins/metrics/public/components/splits/terms.js

@@ -158,4 +158,4 @@ SplitByTermsUi.propTypes = {
   fields: PropTypes.object
 };
 
-export const SplitByTerms = injectI18n(SplitByTermsUi);
+export const SplitByTerms = injectI18n(SplitByTermsUi);

src/legacy/core_plugins/testbed/public/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-import './testbed';
+import './testbed';

src/legacy/core_plugins/timelion/server/fit_functions/nearest.js

@@ -43,4 +43,4 @@ export default function nearest(dataTuples, targetTuples) {
 
     return [bucket[0], closest[1]];
   });
-}
+}

src/legacy/core_plugins/timelion/server/fit_functions/none.js

@@ -23,4 +23,4 @@
 // Does not resample at all.
 export default function none(dataTuples) {
   return dataTuples;
-}
+}

src/legacy/core_plugins/timelion/server/lib/to_milliseconds.js

@@ -51,4 +51,4 @@ export default function (expr) {
 
     return parseFloat(match[1] || 1) * vals[match[2]];
   }
-}
+}

src/legacy/server/index_patterns/service/lib/errors.test.js

@@ -20,4 +20,4 @@
 test('test', () => {
   // errors module is tested in test/api_integration/apis/index_patterns/es_errors/errors.js
   // so it can get real errors from elasticsearch and the es client to test with
-});
+});

src/legacy/server/sample_data/data_sets/flights/field_mappings.js

@@ -102,4 +102,4 @@ export const fieldMappings = {
   FlightTimeHour: {
     type: 'keyword'
   }
-};
+};

src/legacy/server/sample_data/routes/lib/create_index_name.test.js

@@ -25,4 +25,4 @@ test('should include sampleDataSetId and dataIndexId in elasticsearch index name
 
 test('should only include sampleDataSetId when sampleDataSetId and dataIndexId are identical', async () => {
   expect(createIndexName('flights', 'flights')).toBe('kibana_sample_data_flights');
-});
+});

src/legacy/ui/public/notify/banners/index.js

@@ -18,4 +18,4 @@
  */
 
 export { GlobalBannerList } from './global_banner_list';
-export { banners } from './banners';
+export { banners } from './banners';

src/legacy/ui/public/persisted_log/create_log_key.test.js

@@ -32,4 +32,4 @@ describe('createLogKey', () => {
   it('should not include a hashed suffix if the identifier is not present', () => {
     expect(createLogKey('foo')).toEqual('kibana.history.foo');
   });
-});
+});

src/legacy/ui/public/vis/map/map_messages.js

@@ -120,4 +120,4 @@ export const createZoomWarningMsg = (function () {
       }
     };
   };
-}());
+}());

test/functional/services/visualizations/index.js

@@ -17,4 +17,4 @@
  * under the License.
  */
 
-export { PieChartProvider } from './pie_chart';
+export { PieChartProvider } from './pie_chart';

x-pack/plugins/cross_cluster_replication/server/lib/license_pre_routing_factory/index.js

@@ -4,4 +4,4 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export { licensePreRoutingFactory } from './license_pre_routing_factory';
+export { licensePreRoutingFactory } from './license_pre_routing_factory';

x-pack/plugins/grokdebugger/common/constants/index.js

@@ -6,4 +6,4 @@
 
 export { ROUTES } from './routes';
 export { PLUGIN } from './plugin';
-export { EDITOR } from './editor';
+export { EDITOR } from './editor';

x-pack/plugins/grokdebugger/server/lib/check_license/index.js

@@ -4,4 +4,4 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export { checkLicense } from './check_license';
+export { checkLicense } from './check_license';

x-pack/plugins/index_lifecycle_management/public/sections/components/index.js

@@ -7,4 +7,4 @@
 export { ActiveBadge } from './active_badge';
 export { LearnMoreLink } from './learn_more_link';
 export { PhaseErrorMessage } from './phase_error_message';
-export { OptionalLabel } from './optional_label';
+export { OptionalLabel } from './optional_label';

x-pack/plugins/index_lifecycle_management/public/sections/components/learn_more_link.js

@@ -34,4 +34,4 @@ export class LearnMoreLinkUi extends React.PureComponent {
 
   }
 }
-export const LearnMoreLink = injectI18n(LearnMoreLinkUi);
+export const LearnMoreLink = injectI18n(LearnMoreLinkUi);

x-pack/plugins/index_lifecycle_management/public/sections/components/phase_error_message.js

@@ -15,4 +15,4 @@ export const PhaseErrorMessage = ({ isShowingErrors }) => {
       />
     </EuiBadge>
   ) : null;
-};
+};

x-pack/plugins/index_lifecycle_management/public/sections/edit_policy/components/node_allocation/index.js

@@ -4,4 +4,4 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export { NodeAllocation } from './node_allocation.container';
+export { NodeAllocation } from './node_allocation.container';

x-pack/plugins/index_lifecycle_management/public/sections/edit_policy/components/set_priority_input.js

@@ -67,4 +67,4 @@ export const SetPriorityInput = props => {
       </ErrableFormRow>
     </EuiDescribedFormGroup>
   );
-};
+};

x-pack/plugins/index_lifecycle_management/public/sections/policy_table/components/policy_table/index.js

@@ -4,4 +4,4 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export { PolicyTable } from './policy_table.container';
+export { PolicyTable } from './policy_table.container';

x-pack/plugins/index_lifecycle_management/public/services/index.js

@@ -5,4 +5,4 @@
  */
 
 export { filterItems } from './filter_items';
-export { sortTable } from './sort_table';
+export { sortTable } from './sort_table';

x-pack/plugins/index_lifecycle_management/public/services/navigation.js

@@ -20,4 +20,4 @@ export const goToPolicyList = () => {
 
 export const getPolicyPath = (policyName) => {
   return encodeURI(`#${BASE_PATH}policies/edit/${encodeURIComponent(policyName)}`);
-};
+};

x-pack/plugins/index_lifecycle_management/public/store/defaults/cold_phase.js

@@ -27,4 +27,4 @@ export const defaultColdPhase = {
 export const defaultEmptyColdPhase = {
   ...defaultColdPhase,
   [PHASE_INDEX_PRIORITY]: ''
-};
+};

x-pack/plugins/index_lifecycle_management/public/store/defaults/delete_phase.js

@@ -18,4 +18,4 @@ export const defaultDeletePhase = {
   [PHASE_ROLLOVER_MINIMUM_AGE]: '',
   [PHASE_ROLLOVER_MINIMUM_AGE_UNITS]: 'd'
 };
-export const defaultEmptyDeletePhase = defaultDeletePhase;
+export const defaultEmptyDeletePhase = defaultDeletePhase;