Add test

elastic · Oct 14, 2020 · 3490170 · 3490170
1 parent 0457c69
commit 3490170
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 24 deletions.
diff --git a/x-pack/plugins/security_solution/public/detections/components/user_info/index.test.tsx b/x-pack/plugins/security_solution/public/detections/components/user_info/index.test.tsx
@@ -4,20 +4,17 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { renderHook } from '@testing-library/react-hooks';
-import { useUserInfo } from './index';
+import { renderHook, act } from '@testing-library/react-hooks';
+import { useUserInfo, ManageUserInfo } from './index';
 
-import { usePrivilegeUser } from '../../containers/detection_engine/alerts/use_privilege_user';
-import { useSignalIndex } from '../../containers/detection_engine/alerts/use_signal_index';
 import { useKibana } from '../../../common/lib/kibana';
-jest.mock('../../containers/detection_engine/alerts/use_privilege_user');
-jest.mock('../../containers/detection_engine/alerts/use_signal_index');
+import * as api from '../../containers/detection_engine/alerts/api';
+
 jest.mock('../../../common/lib/kibana');
+jest.mock('../../containers/detection_engine/alerts/api');
 
 describe('useUserInfo', () => {
   beforeAll(() => {
-    (usePrivilegeUser as jest.Mock).mockReturnValue({});
-    (useSignalIndex as jest.Mock).mockReturnValue({});
     (useKibana as jest.Mock).mockReturnValue({
       services: {
         application: {
@@ -30,22 +27,40 @@ describe('useUserInfo', () => {
       },
     });
   });
-  it('returns default state', () => {
-    const { result } = renderHook(() => useUserInfo());
+  it('returns default state', async () => {
+    await act(async () => {
+      const { result, waitForNextUpdate } = renderHook(() => useUserInfo());
+      await waitForNextUpdate();
 
-    expect(result).toEqual({
-      current: {
-        canUserCRUD: null,
-        hasEncryptionKey: null,
-        hasIndexManage: null,
-        hasIndexWrite: null,
-        isAuthenticated: null,
-        isSignalIndexExists: null,
-        loading: true,
-        signalIndexName: null,
-        signalIndexTemplateOutdated: null,
-      },
-      error: undefined,
+      expect(result).toEqual({
+        current: {
+          canUserCRUD: null,
+          hasEncryptionKey: null,
+          hasIndexManage: null,
+          hasIndexWrite: null,
+          isAuthenticated: null,
+          isSignalIndexExists: null,
+          loading: true,
+          signalIndexName: null,
+          signalIndexTemplateOutdated: null,
+        },
+        error: undefined,
+      });
+    });
+  });
+
+  it('calls createSignalIndex if signal index template is outdated', async () => {
+    const spyOnCreateSignalIndex = jest.spyOn(api, 'createSignalIndex');
+    const spyOnGetSignalIndex = jest.spyOn(api, 'getSignalIndex').mockResolvedValueOnce({
+      name: 'mock-signal-index',
+      template_outdated: true,
+    });
+    await act(async () => {
+      const { waitForNextUpdate } = renderHook(() => useUserInfo(), { wrapper: ManageUserInfo });
+      await waitForNextUpdate();
+      await waitForNextUpdate();
     });
+    expect(spyOnGetSignalIndex).toHaveBeenCalledTimes(2);
+    expect(spyOnCreateSignalIndex).toHaveBeenCalledTimes(1);
   });
 });
diff --git a/x-pack/plugins/security_solution/public/detections/components/user_info/index.tsx b/x-pack/plugins/security_solution/public/detections/components/user_info/index.tsx
@@ -180,7 +180,7 @@ export const useUserInfo = (): State => {
     typeof uiCapabilities.siem.crud === 'boolean' ? uiCapabilities.siem.crud : false;
 
   useEffect(() => {
-    if (loading !== privilegeLoading || indexNameLoading) {
+    if (loading !== (privilegeLoading || indexNameLoading)) {
       dispatch({ type: 'updateLoading', loading: privilegeLoading || indexNameLoading });
     }
   }, [dispatch, loading, privilegeLoading, indexNameLoading]);