Skip to content

Commit

Permalink
[Discover] Rename Legacy table to Classic table and Data grid to New …
Browse files Browse the repository at this point in the history
…table (#99336)

* Rename "Legacy table" to "Classic table"

* Rename "Data grid" to "New table"
  • Loading branch information
kertal authored May 6, 2021
1 parent 79be58e commit 3389274
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import { OptionsPopover } from './open_options_popover';
test('should display the correct text if datagrid is selected', () => {
const element = document.createElement('div');
const component = mountWithIntl(<OptionsPopover onClose={jest.fn()} anchorElement={element} />);
expect(findTestSubject(component, 'docTableMode').text()).toBe('Data grid');
expect(findTestSubject(component, 'docTableMode').text()).toBe('New table');
});

test('should display the correct text if legacy table is selected', () => {
Expand All @@ -45,5 +45,5 @@ test('should display the correct text if legacy table is selected', () => {
uiSettings.set('doc_table:legacy', true);
const element = document.createElement('div');
const component = mountWithIntl(<OptionsPopover onClose={jest.fn()} anchorElement={element} />);
expect(findTestSubject(component, 'docTableMode').text()).toBe('Legacy table');
expect(findTestSubject(component, 'docTableMode').text()).toBe('Classic table');
});
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ export function OptionsPopover(props: OptionsPopoverProps) {

const mode = isLegacy
? i18n.translate('discover.openOptionsPopover.legacyTableText', {
defaultMessage: 'Legacy table',
defaultMessage: 'Classic table',
})
: i18n.translate('discover.openOptionsPopover.dataGridText', {
defaultMessage: 'Data grid',
defaultMessage: 'New table',
});

return (
Expand Down Expand Up @@ -64,7 +64,7 @@ export function OptionsPopover(props: OptionsPopoverProps) {
<EuiText color="subdued" size="s">
<FormattedMessage
id="discover.topNav.openOptionsPopover.description"
defaultMessage="The new data grid layout includes enhanced data sorting, drag-and-drop columns, multi-document selection, and a full screen view. Toggle 'Use legacy table' in Advanced Settings to switch modes."
defaultMessage="Great news! Discover has better ways to sort data, drag and drop columns, and compare documents. Toggle 'Use classic table' in Advanced Settings to get started."
/>
</EuiText>
<EuiSpacer />
Expand All @@ -74,7 +74,7 @@ export function OptionsPopover(props: OptionsPopoverProps) {
href={addBasePath(`/app/management/kibana/settings?query=${DOC_TABLE_LEGACY}`)}
>
{i18n.translate('discover.openOptionsPopover.goToAdvancedSettings', {
defaultMessage: 'Go to Advanced Settings',
defaultMessage: 'Get started',
})}
</EuiButton>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/discover/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,13 @@ export const getUiSettings: () => Record<string, UiSettingsParams> = () => ({
},
[DOC_TABLE_LEGACY]: {
name: i18n.translate('discover.advancedSettings.docTableVersionName', {
defaultMessage: 'Use legacy table',
defaultMessage: 'Use classic table',
}),
value: true,
description: i18n.translate('discover.advancedSettings.docTableVersionDescription', {
defaultMessage:
'Discover uses a new table layout that includes better data sorting, drag-and-drop columns, and a full screen ' +
'view. Enable this option if you prefer to fall back to the legacy table.',
'Discover uses a new table layout that includes better data sorting, drag-and-drop columns, and a full screen view. ' +
'Turn on this option to use the classic table. Turn off to use the new table. ',
}),
category: ['discover'],
schema: schema.boolean(),
Expand Down

0 comments on commit 3389274

Please sign in to comment.