Removes duplicate code, moves component contents inline

elastic · Sep 2, 2021 · 317a448 · 317a448
1 parent 7fac104
commit 317a448
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/...cts_management/public/management_section/objects_table/components/import_mode_control.tsx b/...cts_management/public/management_section/objects_table/components/import_mode_control.tsx
@@ -99,16 +99,6 @@ export const ImportModeControl = ({ initialValues, updateSelection }: ImportMode
     updateSelection({ createNewCopies, overwrite, ...partial });
   };
 
-  const overwriteRadio = (
-    <EuiRadioGroup
-      options={[overwriteEnabled, overwriteDisabled]}
-      idSelected={overwrite ? overwriteEnabled.id : overwriteDisabled.id}
-      onChange={(id: string) => onChange({ overwrite: id === overwriteEnabled.id })}
-      disabled={createNewCopies}
-      data-test-subj={'savedObjectsManagement-importModeControl-overwriteRadioGroup'}
-    />
-  );
-
   return (
     <EuiFormFieldset
       legend={{
@@ -125,7 +115,13 @@ export const ImportModeControl = ({ initialValues, updateSelection }: ImportMode
         checked={!createNewCopies}
         onChange={() => onChange({ createNewCopies: false })}
       >
-        {overwriteRadio}
+        <EuiRadioGroup
+          options={[overwriteEnabled, overwriteDisabled]}
+          idSelected={overwrite ? overwriteEnabled.id : overwriteDisabled.id}
+          onChange={(id: string) => onChange({ overwrite: id === overwriteEnabled.id })}
+          disabled={createNewCopies}
+          data-test-subj={'savedObjectsManagement-importModeControl-overwriteRadioGroup'}
+        />
       </EuiCheckableCard>
 
       <EuiSpacer size="s" />

diff --git a/test/functional/page_objects/management/saved_objects_page.ts b/test/functional/page_objects/management/saved_objects_page.ts
@@ -61,7 +61,6 @@ export class SavedObjectsPageObject extends FtrService {
 
   async checkImportSucceeded() {
     await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });
-    await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });
   }
 
   async checkNoneImported() {