Apply suggestions from code review

Co-authored-by: Constance <[email protected]>
elastic · Feb 25, 2021 · 31070ee · 31070ee
1 parent 2cd7cd1
commit 31070ee
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 17 deletions.
diff --git a/...rprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx b/...rprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx
@@ -183,13 +183,6 @@ describe('EnginesOverview', () => {
           ...valuesWithEngines,
           myRole: { canViewMetaEngines: true },
           metaEngines: ['test-meta-engine'],
-          metaEnginesMeta: {
-            page: {
-              current: 1,
-              size: 10,
-              total_results: 100,
-            },
-          },
         });
         const wrapper = shallow(<EnginesOverview />);
         const pageEvent = { page: { index: 0 } };

diff --git a/.../enterprise_search/public/applications/app_search/components/engines/engines_overview.tsx b/.../enterprise_search/public/applications/app_search/components/engines/engines_overview.tsx
@@ -67,8 +67,8 @@ export const EnginesOverview: React.FC = () => {
   }, [enginesMeta.page.current]);
 
   useEffect(() => {
-    if (canViewMetaEngines) loadMetaEngines();
-  }, [canViewMetaEngines, metaEnginesMeta.page.current]);
+    if (hasPlatinumLicense) loadMetaEngines();
+  }, [hasPlatinumLicense, metaEnginesMeta.page.current]);
 
   if (dataLoading) return <LoadingState />;
   if (!engines.length) return <EmptyState />;
@@ -112,7 +112,7 @@ export const EnginesOverview: React.FC = () => {
           />
         </EuiPageContentBody>
 
-        {canViewMetaEngines && (
+        {hasPlatinumLicense && (
           <>
             <EuiSpacer size="xl" />
             <EuiPageContentHeader>

diff --git a/...prise_search/public/applications/app_search/components/meta_engine_creation/constants.tsx b/...prise_search/public/applications/app_search/components/meta_engine_creation/constants.tsx
@@ -37,7 +37,7 @@ export const META_ENGINE_CREATION_FORM_META_ENGINE_DESCRIPTION = i18n.translate(
   'xpack.enterpriseSearch.appSearch.metaEngineCreation.form.metaEngineDescription',
   {
     defaultMessage:
-      'Meta engines allow you to combine multiple engines into one, searchable engine.',
+      'Meta engines allow you to combine multiple engines into one searchable engine.',
   }
 );
 
@@ -54,12 +54,12 @@ export const META_ENGINE_CREATION_FORM_DOCUMENTATION_DESCRIPTION = (
     defaultMessage="{documentationLink} for information about how to get started."
     values={{
       documentationLink: (
-        <a
-          href="https://www.elastic.co/guide/en/app-search/current/meta-engines-guide.html"
+        <EuiLink
+          href={`${DOCS_PREFIX}/meta-engines-guide.html`}
           target="_blank"
         >
           {META_ENGINE_CREATION_FORM_DOCUMENTATION_LINK}
-        </a>
+        </EuiLink>
       ),
     }}
   />

diff --git a/...lic/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts b/...lic/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts
@@ -79,12 +79,12 @@ export const MetaEngineCreationLogic = kea<
   listeners: ({ values, actions }) => ({
     fetchIndexedEngineNames: async ({ page }) => {
       const { http } = HttpLogic.values;
-      let response;
+      let response: { results: EngineDetails[]; meta: Meta } | undefined;
 
       try {
-        response = (await http.get('/api/app_search/engines', {
+        response = await http.get('/api/app_search/engines', {
           query: { type: 'indexed', 'page[current]': page, 'page[size]': DEFAULT_META.page.size },
-        })) as { results: EngineDetails[]; meta: Meta };
+        });
       } catch (e) {
         flashAPIErrors(e);
       }