tidy: PR feedback

elastic · Sep 13, 2021 · 2d5334f · 2d5334f
1 parent fb12f1c
commit 2d5334f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/x-pack/plugins/fleet/public/components/package_policy_actions_menu.test.tsx b/x-pack/plugins/fleet/public/components/package_policy_actions_menu.test.tsx
@@ -18,12 +18,12 @@ function renderMenu({
   agentPolicy,
   packagePolicy,
   showAddAgent = false,
-  isOpen = true,
+  defaultIsOpen = true,
 }: {
   agentPolicy: AgentPolicy;
   packagePolicy: InMemoryPackagePolicy;
   showAddAgent?: boolean;
-  isOpen?: boolean;
+  defaultIsOpen?: boolean;
 }) {
   const renderer = createIntegrationsTestRendererMock();
 
@@ -33,7 +33,7 @@ function renderMenu({
       packagePolicy={packagePolicy}
       showAddAgent={showAddAgent}
       upgradePackagePolicyHref=""
-      isOpen={isOpen}
+      defaultIsOpen={defaultIsOpen}
       key="test1"
     />
   );
@@ -87,17 +87,17 @@ test('Should disable upgrade button if package does not have upgrade', async ()
   const packagePolicy = createMockPackagePolicy({ hasUpgrade: false });
   const { utils } = renderMenu({ agentPolicy, packagePolicy });
   await act(async () => {
-    const upgradeButton = utils.getByText('Upgrade package policy').closest('button');
+    const upgradeButton = utils.getByText('Upgrade integration policy').closest('button');
     expect(upgradeButton).toBeDisabled();
   });
 });
 
-test('Should enable upgrade button if package does has upgrade', async () => {
+test('Should enable upgrade button if package has upgrade', async () => {
   const agentPolicy = createMockAgentPolicy();
   const packagePolicy = createMockPackagePolicy({ hasUpgrade: true });
   const { utils } = renderMenu({ agentPolicy, packagePolicy });
   await act(async () => {
-    const upgradeButton = utils.getByText('Upgrade package policy').closest('button');
+    const upgradeButton = utils.getByText('Upgrade integration policy').closest('button');
     expect(upgradeButton).not.toBeDisabled();
   });
 });

diff --git a/x-pack/plugins/fleet/public/components/package_policy_actions_menu.tsx b/x-pack/plugins/fleet/public/components/package_policy_actions_menu.tsx
@@ -24,21 +24,21 @@ export const PackagePolicyActionsMenu: React.FunctionComponent<{
   packagePolicy: InMemoryPackagePolicy;
   viewDataStep?: EuiStepProps;
   showAddAgent?: boolean;
-  isOpen?: boolean;
+  defaultIsOpen?: boolean;
   upgradePackagePolicyHref: string;
 }> = ({
   agentPolicy,
   packagePolicy,
   viewDataStep,
   showAddAgent,
   upgradePackagePolicyHref,
-  isOpen = false,
+  defaultIsOpen = false,
 }) => {
   const [isEnrollmentFlyoutOpen, setIsEnrollmentFlyoutOpen] = useState(false);
   const { getHref } = useLink();
   const hasWriteCapabilities = useCapabilities().write;
   const refreshAgentPolicy = useAgentPolicyRefresh();
-  const [isActionsMenuOpen, setIsActionsMenuOpen] = useState(isOpen);
+  const [isActionsMenuOpen, setIsActionsMenuOpen] = useState(defaultIsOpen);
 
   const onEnrollmentFlyoutClose = useMemo(() => {
     return () => setIsEnrollmentFlyoutOpen(false);