PR comments

elastic · Dec 17, 2024 · 2d2b681 · 2d2b681
1 parent 1119875
commit 2d2b681
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 21 deletions.
diff --git a/...plugins/security_solution/public/flyout/document_details/left/components/session_view.tsx b/...plugins/security_solution/public/flyout/document_details/left/components/session_view.tsx
@@ -94,7 +94,7 @@ export const SessionView: FC = () => {
     [openPreviewPanel, eventDetailsIndex, scopeId, telemetry]
   );
 
-  const openDetails = useCallback(
+  const openDetailsInPreview = useCallback(
     (selectedProcess: Process | null) => {
       // We cannot pass the original Process object sent from the SessionView component
       // as it contains functions (that should not put into Redux)
@@ -143,7 +143,8 @@ export const SessionView: FC = () => {
         ...sessionViewConfig,
         isFullScreen: true,
         loadAlertDetails: openAlertDetailsPreview,
-        openDetails: (selectedProcess: Process | null) => openDetails(selectedProcess),
+        openDetailsInExpandableFlyout: (selectedProcess: Process | null) =>
+          openDetailsInPreview(selectedProcess),
         canReadPolicyManagement,
         resetJumpToEntityId: jumpToEntityId,
         resetJumpToCursor: jumpToCursor,

diff --git a/x-pack/solutions/security/plugins/security_solution/public/flyout/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/flyout/index.tsx
@@ -112,7 +112,7 @@ const expandableFlyoutDocumentsPanels: ExpandableFlyoutProps['registeredPanels']
     key: DocumentDetailsSessionViewPanelKey,
     component: (props) => (
       <SessionViewPanelProvider {...(props as SessionViewPanelProps).params}>
-        <SessionViewPanel path={props.path as IsolateHostPanelProps['path']} />
+        <SessionViewPanel path={props.path as SessionViewPanelProps['path']} />
       </SessionViewPanelProvider>
     ),
   },

diff --git a/x-pack/solutions/security/plugins/session_view/public/components/process_tree_node/index.tsx b/x-pack/solutions/security/plugins/session_view/public/components/process_tree_node/index.tsx
@@ -316,14 +316,12 @@ export function ProcessTreeNode({
               <Nbsp />
               <span css={styles.jumpToTop}>
                 <EuiToolTip title={COLLAPSE_ALL}>
-                  <EuiToolTip title={COLLAPSE_ALL}>
-                    <EuiButtonIcon
-                      size="xs"
-                      iconType="fold"
-                      onClick={handleCollapseProcessTree}
-                      aria-label={COLLAPSE_ALL}
-                    />
-                  </EuiToolTip>
+                  <EuiButtonIcon
+                    size="xs"
+                    iconType="fold"
+                    onClick={handleCollapseProcessTree}
+                    aria-label={COLLAPSE_ALL}
+                  />
                 </EuiToolTip>
               </span>
             </span>

diff --git a/x-pack/solutions/security/plugins/session_view/public/components/session_view/index.tsx b/x-pack/solutions/security/plugins/session_view/public/components/session_view/index.tsx
@@ -62,7 +62,7 @@ export const SessionView = ({
   loadAlertDetails,
   canReadPolicyManagement,
   trackEvent,
-  openDetails,
+  openDetailsInExpandableFlyout,
   resetJumpToEntityId,
   resetJumpToCursor,
 }: SessionViewDeps & { trackEvent: (name: SessionViewTelemetryKey) => void }) => {
@@ -123,11 +123,11 @@ export const SessionView = ({
 
       // used when SessionView is displayed in the expandable flyout
       // This refreshes the detailed panel rendered in the flyout preview panel
-      if (openDetails) {
-        openDetails(process);
+      if (openDetailsInExpandableFlyout) {
+        openDetailsInExpandableFlyout(process);
       }
     },
-    [openDetails]
+    [openDetailsInExpandableFlyout]
   );
 
   const onJumpToEvent = useCallback(
@@ -287,10 +287,10 @@ export const SessionView = ({
   }, [isDetailOpen, trackEvent]);
 
   const toggleDetailPanelInFlyout = useCallback(() => {
-    if (openDetails) {
-      openDetails(selectedProcess);
+    if (openDetailsInExpandableFlyout) {
+      openDetailsInExpandableFlyout(selectedProcess);
     }
-  }, [openDetails, selectedProcess]);
+  }, [openDetailsInExpandableFlyout, selectedProcess]);
 
   const onShowAlertDetails = useCallback(
     (alertUuid: string) => {
@@ -501,7 +501,7 @@ export const SessionView = ({
           </EuiFlexItem>
 
           <EuiFlexItem grow={false}>
-            {openDetails ? (
+            {openDetailsInExpandableFlyout ? (
               <EuiButtonIcon onClick={toggleDetailPanelInFlyout} iconType="expand" />
             ) : (
               <EuiButton
@@ -517,7 +517,7 @@ export const SessionView = ({
         </EuiFlexGroup>
       </EuiPanel>
       <EuiHorizontalRule margin="none" />
-      {openDetails ? (
+      {openDetailsInExpandableFlyout ? (
         <>
           {errorEmptyPrompt}
           {processTree}

diff --git a/x-pack/solutions/security/plugins/session_view/public/types.ts b/x-pack/solutions/security/plugins/session_view/public/types.ts
@@ -89,7 +89,7 @@ export interface SessionViewDeps {
    * Allows to open the detailed panel outside of the SessionView component. This is necessary when the session view is rendered in the
    * expandable flyout, where the tree and the detailed panel are separated and need to communicate with each other.
    */
-  openDetails?: (selectedProcess: Process | null) => void;
+  openDetailsInExpandableFlyout?: (selectedProcess: Process | null) => void;
   /**
    * Allows to reset the view from an external component. This is necessary when the session view is rendered in the
    * expandable flyout, where the tree and the detailed panels are separated and need to communicate with each other.