Move vis registration to NP

x-pack/legacy/plugins/maps/index.js

@@ -76,7 +76,6 @@ export function maps(kibana) {
       },
       mappings,
       migrations,
-      hacks: ['plugins/maps/register_vis_type_alias'],
     },
     config(Joi) {
       return Joi.object({

x-pack/plugins/maps/kibana.json

@@ -9,7 +9,8 @@
     "data",
     "fileUpload",
     "uiActions",
-    "navigation"
+    "navigation",
+    "visualizations"
   ],
   "ui": true
 }

x-pack/plugins/maps/public/maps_vis_type_alias.js

@@ -0,0 +1,46 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { i18n } from '@kbn/i18n';
+import { APP_ID, APP_ICON, MAP_BASE_URL } from '../../../legacy/plugins/maps/common/constants';
+import {
+  getInjectedVarFunc,
+  getVisualizations,
+} from './kibana_services';
+
+export function getMapsVisTypeAlias() {
+  const showMapVisualizationTypes = getInjectedVarFunc()('showMapVisualizationTypes', false);
+  if (!showMapVisualizationTypes) {
+    getVisualizations().hideTypes(['region_map', 'tile_map']);
+  }
+
+  const description = i18n.translate('xpack.maps.visTypeAlias.description', {
+    defaultMessage: 'Create and style maps with multiple layers and indices.',
+  });
+
+  const legacyMapVisualizationWarning = i18n.translate(
+    'xpack.maps.visTypeAlias.legacyMapVizWarning',
+    {
+      defaultMessage: `Use the Maps app instead of Coordinate Map and Region Map.
+The Maps app offers more functionality and is easier to use.`,
+    }
+  );
+
+  return ({
+    aliasUrl: MAP_BASE_URL,
+    name: APP_ID,
+    title: i18n.translate('xpack.maps.visTypeAlias.title', {
+      defaultMessage: 'Maps',
+    }),
+    description: showMapVisualizationTypes
+      ? `${description} ${legacyMapVisualizationWarning}`
+      : description,
+    icon: APP_ICON,
+    stage: 'production',
+  });
+
+}
+

x-pack/plugins/maps/public/plugin.ts

@@ -34,6 +34,7 @@ import {
   // @ts-ignore
 } from './kibana_services';
 import { featureCatalogueEntry } from './feature_catalogue_entry';
+import { getMapsVisTypeAlias } from './maps_vis_type_alias';
 
 export interface MapsPluginSetupDependencies {
   inspector: InspectorSetupContract;
@@ -97,6 +98,7 @@ export class MapsPlugin
 
     plugins.inspector.registerView(MapView);
     plugins.home.featureCatalogue.register(featureCatalogueEntry);
+    plugins.visualizations.registerAlias(getMapsVisTypeAlias());
   }
 
   public start(core: CoreStart, plugins: any) {