Skip to content

Commit

Permalink
remove unused code and added signal refs
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelolo24 committed Nov 23, 2021
1 parent afb25e9 commit 2c1a31c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@
*/

/** actions are disabled for these fields in tables and popovers */
export const FIELDS_WITHOUT_CELL_ACTIONS = ['kibana.alert.rule.risk_score', 'kibana.alert.reason'];
export const FIELDS_WITHOUT_CELL_ACTIONS = [
'signal.rule.risk_score',
'signal.reason',
'kibana.alert.rule.risk_score',
'kibana.alert.reason',
];
10 changes: 0 additions & 10 deletions x-pack/plugins/timelines/public/components/t_grid/body/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,16 +147,6 @@ const EuiDataGridContainer = styled.div<{ hideLastPage: boolean }>`
}
`;

// TODO: accept extra list of column ids without actions from callsites
const FIELDS_WITHOUT_CELL_ACTIONS = [
'@timestamp',
'signal.rule.risk_score',
'kibana.alert.rule.risk_score',
'signal.reason',
'kibana.alert.reason',
'kibana.alert.duration.us',
];

const transformControlColumns = ({
columnHeaders,
controlColumns,
Expand Down

0 comments on commit 2c1a31c

Please sign in to comment.