Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.5] [Profiling] Add APIs to clear frame and executable caches (#145499
) (#145524) # Backport This will backport the following commits from `main` to `8.5`: - [[Profiling] Add APIs to clear frame and executable caches (#145499)](#145499) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joseph Crail","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T10:04:58Z","message":"[Profiling] Add APIs to clear frame and executable caches (#145499)\n\nThis PR adds two endpoints to clear each respective cache:\r\n\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables`\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/stackframes`\r\n\r\nRelated to https://github.com/elastic/prodfiler/issues/2759\r\n\r\n#### Design choices\r\n\r\n1. The `DELETE` method was chosen instead of `PUT` or `POST` since the\r\ngiven semantics of `DELETE` matches the expected behavior for the\r\nrelated issue.\r\n2. Each endpoint will remove all items from the respective cache. A\r\nseparate API for each cache allows us to selectively clear the necessary\r\ncache without the downsides of a catch-all endpoint to clear all caches.\r\nThis gives us the flexibility to add more endpoints if needed. Given the\r\ntradeoff between complexity now or later, it was decided to implement\r\ngeneral invalidation now with the option to invalidate specific items\r\nlater.\r\n3. The RESTful design allows us to clear specific items later (e.g.\r\n`DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables/{ID}`\r\ncould clear only executable `ID` from the cache).\r\n4. Each endpoint returns an empty payload on success. However, the\r\nKibana logs reflect the actions taken and how many cache items were\r\naffected.\r\n5. The stacktrace cache was ignored since it was not affected by symbols\r\nwritten to Elasticsearch.\r\n6. Each endpoint is not directly accessible from UI since it is expected\r\nthat the endpoints will be called outside of Kibana. However, the\r\nendpoints can be called manually from the browser's console.","sha":"642ab74cfc1a4ef5c0a2dfdadf00bd3792f780a7","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.6.0","v8.7.0","v8.5.2"],"number":145499,"url":"https://github.com/elastic/kibana/pull/145499","mergeCommit":{"message":"[Profiling] Add APIs to clear frame and executable caches (#145499)\n\nThis PR adds two endpoints to clear each respective cache:\r\n\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables`\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/stackframes`\r\n\r\nRelated to https://github.com/elastic/prodfiler/issues/2759\r\n\r\n#### Design choices\r\n\r\n1. The `DELETE` method was chosen instead of `PUT` or `POST` since the\r\ngiven semantics of `DELETE` matches the expected behavior for the\r\nrelated issue.\r\n2. Each endpoint will remove all items from the respective cache. A\r\nseparate API for each cache allows us to selectively clear the necessary\r\ncache without the downsides of a catch-all endpoint to clear all caches.\r\nThis gives us the flexibility to add more endpoints if needed. Given the\r\ntradeoff between complexity now or later, it was decided to implement\r\ngeneral invalidation now with the option to invalidate specific items\r\nlater.\r\n3. The RESTful design allows us to clear specific items later (e.g.\r\n`DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables/{ID}`\r\ncould clear only executable `ID` from the cache).\r\n4. Each endpoint returns an empty payload on success. However, the\r\nKibana logs reflect the actions taken and how many cache items were\r\naffected.\r\n5. The stacktrace cache was ignored since it was not affected by symbols\r\nwritten to Elasticsearch.\r\n6. Each endpoint is not directly accessible from UI since it is expected\r\nthat the endpoints will be called outside of Kibana. However, the\r\nendpoints can be called manually from the browser's console.","sha":"642ab74cfc1a4ef5c0a2dfdadf00bd3792f780a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145499","number":145499,"mergeCommit":{"message":"[Profiling] Add APIs to clear frame and executable caches (#145499)\n\nThis PR adds two endpoints to clear each respective cache:\r\n\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables`\r\n* `DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/stackframes`\r\n\r\nRelated to https://github.com/elastic/prodfiler/issues/2759\r\n\r\n#### Design choices\r\n\r\n1. The `DELETE` method was chosen instead of `PUT` or `POST` since the\r\ngiven semantics of `DELETE` matches the expected behavior for the\r\nrelated issue.\r\n2. Each endpoint will remove all items from the respective cache. A\r\nseparate API for each cache allows us to selectively clear the necessary\r\ncache without the downsides of a catch-all endpoint to clear all caches.\r\nThis gives us the flexibility to add more endpoints if needed. Given the\r\ntradeoff between complexity now or later, it was decided to implement\r\ngeneral invalidation now with the option to invalidate specific items\r\nlater.\r\n3. The RESTful design allows us to clear specific items later (e.g.\r\n`DELETE {BASE_KIBANA_PATH}/api/profiling/v1/cache/executables/{ID}`\r\ncould clear only executable `ID` from the cache).\r\n4. Each endpoint returns an empty payload on success. However, the\r\nKibana logs reflect the actions taken and how many cache items were\r\naffected.\r\n5. The stacktrace cache was ignored since it was not affected by symbols\r\nwritten to Elasticsearch.\r\n6. Each endpoint is not directly accessible from UI since it is expected\r\nthat the endpoints will be called outside of Kibana. However, the\r\nendpoints can be called manually from the browser's console.","sha":"642ab74cfc1a4ef5c0a2dfdadf00bd3792f780a7"}},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joseph Crail <[email protected]> Co-authored-by: Tim Rühsen <[email protected]>
- Loading branch information