Rename hideChart to isLoadingWithoutChart

elastic · Jul 18, 2023 · 2741ba5 · 2741ba5
1 parent ce1803e
commit 2741ba5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/...gers_actions_ui/public/application/sections/alert_summary_widget/alert_summary_widget.tsx b/...gers_actions_ui/public/application/sections/alert_summary_widget/alert_summary_widget.tsx
@@ -34,7 +34,8 @@ export const AlertSummaryWidget = ({
     timeRange,
   });
 
-  if (isLoading) return <AlertSummaryWidgetLoader fullSize={fullSize} hideChart={hideChart} />;
+  if (isLoading)
+    return <AlertSummaryWidgetLoader fullSize={fullSize} isLoadingWithoutChart={hideChart} />;
 
   if (error) return <AlertSummaryWidgetError />;
 

diff --git a/...blic/application/sections/alert_summary_widget/components/alert_summary_widget_loader.tsx b/...blic/application/sections/alert_summary_widget/components/alert_summary_widget_loader.tsx
@@ -9,19 +9,22 @@ import React from 'react';
 import { EuiLoadingChart, EuiLoadingSpinner } from '@elastic/eui';
 import { AlertSummaryWidgetProps } from '..';
 
-type Props = Pick<AlertSummaryWidgetProps, 'fullSize' | 'hideChart'>;
+type Props = { isLoadingWithoutChart: boolean | undefined } & Pick<
+  AlertSummaryWidgetProps,
+  'fullSize'
+>;
 
-export const AlertSummaryWidgetLoader = ({ fullSize, hideChart }: Props) => {
+export const AlertSummaryWidgetLoader = ({ fullSize, isLoadingWithoutChart }: Props) => {
   return (
     <div
       style={{
-        minHeight: hideChart ? 44 : fullSize ? 238 : 224,
+        minHeight: isLoadingWithoutChart ? 44 : fullSize ? 238 : 224,
         display: 'flex',
         alignItems: 'center',
-        justifyContent: hideChart ? 'flex-start' : 'center',
+        justifyContent: isLoadingWithoutChart ? 'flex-start' : 'center',
       }}
     >
-      {hideChart ? (
+      {isLoadingWithoutChart ? (
         <EuiLoadingSpinner size="m" />
       ) : (
         <EuiLoadingChart size="l" data-test-subj="alertSummaryWidgetLoading" />