🐛 Store initial value and use it as placeholder + as fallback for chart

elastic · Feb 11, 2021 · 26ad78d · 26ad78d
1 parent 9f38e3a
commit 26ad78d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx
@@ -59,6 +59,9 @@ const LabelInput = ({ value, onChange }: { value: string; onChange: (value: stri
   const [inputValue, setInputValue] = useState(value);
   const unflushedChanges = useRef(false);
 
+  // Save the initial value
+  const initialValue = useRef(value);
+
   const onChangeDebounced = useMemo(() => {
     const callback = _.debounce((val: string) => {
       onChange(val);
@@ -79,7 +82,7 @@ const LabelInput = ({ value, onChange }: { value: string; onChange: (value: stri
   const handleInputChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     const val = String(e.target.value);
     setInputValue(val);
-    onChangeDebounced(val);
+    onChangeDebounced(val || initialValue.current);
   };
 
   return (
@@ -96,6 +99,7 @@ const LabelInput = ({ value, onChange }: { value: string; onChange: (value: stri
         data-test-subj="indexPattern-label-edit"
         value={inputValue}
         onChange={handleInputChange}
+        placeholder={initialValue.current}
       />
     </EuiFormRow>
   );