Fix error, tweak border styles

elastic · Jun 18, 2024 · 25dac89 · 25dac89
1 parent 6fe6382
commit 25dac89
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/packages/kbn-text-based-editor/src/editor_footer.tsx b/packages/kbn-text-based-editor/src/editor_footer.tsx
@@ -145,7 +145,6 @@ export const EditorFooter = memo(function EditorFooter({
   queryHasChanged,
   measuredContainerWidth,
 }: EditorFooterProps) {
-  const { euiTheme } = useEuiTheme();
   const [isErrorPopoverOpen, setIsErrorPopoverOpen] = useState(false);
   const [isWarningPopoverOpen, setIsWarningPopoverOpen] = useState(false);
   const onUpdateAndSubmit = useCallback(
@@ -162,10 +161,6 @@ export const EditorFooter = memo(function EditorFooter({
     [runQuery, updateQuery]
   );
 
-  const shadowStyle = isInCompactMode
-    ? `inset 0 0px 0, inset 0 -1px 0 ${euiTheme.border.color}`
-    : 'none';
-
   return (
     <EuiFlexGroup
       gutterSize="none"

diff --git a/packages/kbn-text-based-editor/src/overwrite.scss b/packages/kbn-text-based-editor/src/overwrite.scss
@@ -2,7 +2,7 @@
 /* NOTE: Much of this is overriding Monaco styles so the specificity is intentional */
 
 // Radius for both the main container and the margin (container for line numbers)
-.TextBasedLangEditor .monaco-editor, .TextBasedLangEditor .monaco-editor .margin {
+.TextBasedLangEditor .monaco-editor, .TextBasedLangEditor .monaco-editor .margin, .TextBasedLangEditor .monaco-editor .overflow-guard {
   border-top-left-radius: $euiBorderRadius;
   border-bottom-left-radius: $euiBorderRadius;
 }
@@ -51,3 +51,8 @@
 .TextBasedLangEditor--expanded .monaco-editor .monaco-hover {
   display: block !important;
 }
+
+.TextBasedLangEditor--expanded .monaco-editor, .TextBasedLangEditor--expanded .monaco-editor .margin, .TextBasedLangEditor--expanded .monaco-editor .overflow-guard {
+  border-top-left-radius: 0;
+  border-bottom-left-radius: 0;
+}
diff --git a/packages/kbn-text-based-editor/src/query_history.tsx b/packages/kbn-text-based-editor/src/query_history.tsx
@@ -364,6 +364,8 @@ export function QueryHistory({
     .euiTable th[data-test-subj='tableHeaderCell_duration_3'] span {
       justify-content: flex-end;
     }
+    border-bottom-left-radius: ${euiTheme.border.radius.medium};
+    border-top-left-radius: ${euiTheme.border.radius.medium};
     max-height: ${isInCompactMode ? CONTAINER_MAX_HEIGHT_COMPACT : CONTAINER_MAX_HEIGHT_EXPANDED}px;
     overflow-y: auto;
     ${scrollBarStyles}

diff --git a/packages/kbn-text-based-editor/src/text_based_languages_editor.styles.ts b/packages/kbn-text-based-editor/src/text_based_languages_editor.styles.ts
@@ -102,7 +102,7 @@ export const textBasedLanguageEditorStyles = (
     },
     historyContainer: {
       border: euiTheme.border.thin,
-      borderTop: `2px solid ${euiTheme.colors.lightShade}`,
+      borderTop: 'none',
       borderLeft: editorIsInline ? 'none' : euiTheme.border.thin,
       borderRight: editorIsInline ? 'none' : euiTheme.border.thin,
       backgroundColor: euiTheme.colors.lightestShade,