Skip to content

Commit

Permalink
[7.x] [ftr] enable visualRegression jobs (#42989) (#43124)
Browse files Browse the repository at this point in the history
* enable visualRegression jobs

* skip the console and login visual tests
  • Loading branch information
Spencer authored Aug 12, 2019
1 parent bbffc90 commit 2441453
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .ci/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ JOB:
- kibana-ciGroup10
- kibana-ciGroup11
- kibana-ciGroup12
# - kibana-visualRegression
- kibana-visualRegression

# make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh
- x-pack-firefoxSmoke
Expand All @@ -28,7 +28,7 @@ JOB:
- x-pack-ciGroup8
- x-pack-ciGroup9
- x-pack-ciGroup10
# - x-pack-visualRegression
- x-pack-visualRegression

# `~` is yaml for `null`
exclude: ~
2 changes: 1 addition & 1 deletion test/visual_regression/tests/console_app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
const visualTesting = getService('visualTesting');
const PageObjects = getPageObjects(['common', 'console']);

describe('console app', function describeIndexTests() {
describe.skip('console app', function describeIndexTests() {
before(async () => {
log.debug('navigateTo console');
await PageObjects.common.navigateToApp('console');
Expand Down
3 changes: 2 additions & 1 deletion x-pack/test/visual_regression/tests/login_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function ({ getService, getPageObjects }) {
const PageObjects = getPageObjects(['common', 'security']);

describe('Security', () => {
describe('Login Page', () => {
describe.skip('Login Page', () => {
before(async () => {
await esArchiver.load('empty_kibana');
await PageObjects.security.logout();
Expand All @@ -28,6 +28,7 @@ export default function ({ getService, getPageObjects }) {

it('renders login page', async () => {
await PageObjects.common.navigateToApp('login');

await retry.waitFor('login page visible', async () => (
await testSubjects.exists('loginSubmit')
));
Expand Down

0 comments on commit 2441453

Please sign in to comment.