Skip to content

Commit

Permalink
[Ingest Manager] Shared Fleet agent policy action (#76013) (#77297)
Browse files Browse the repository at this point in the history
  • Loading branch information
nchaulet authored Sep 14, 2020
1 parent 4bcb2ba commit 23eaf58
Show file tree
Hide file tree
Showing 16 changed files with 397 additions and 355 deletions.
31 changes: 28 additions & 3 deletions x-pack/plugins/ingest_manager/common/types/models/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,53 @@ export type AgentStatus =
| 'unenrolling'
| 'degraded';

export type AgentActionType = 'CONFIG_CHANGE' | 'DATA_DUMP' | 'RESUME' | 'PAUSE' | 'UNENROLL';
export type AgentActionType = 'CONFIG_CHANGE' | 'UNENROLL';

export interface NewAgentAction {
type: AgentActionType;
data?: any;
sent_at?: string;
}

export interface AgentAction extends NewAgentAction {
type: AgentActionType;
data?: any;
sent_at?: string;
id: string;
agent_id: string;
created_at: string;
ack_data?: any;
}

export interface AgentPolicyAction extends NewAgentAction {
id: string;
type: AgentActionType;
data?: any;
policy_id: string;
policy_revision: number;
created_at: string;
ack_data?: any;
}

export interface AgentActionSOAttributes {
interface CommonAgentActionSOAttributes {
type: AgentActionType;
sent_at?: string;
timestamp?: string;
created_at: string;
agent_id: string;
data?: string;
ack_data?: string;
}

export type AgentActionSOAttributes = CommonAgentActionSOAttributes & {
agent_id: string;
};
export type AgentPolicyActionSOAttributes = CommonAgentActionSOAttributes & {
policy_id: string;
policy_revision: number;
};

export type BaseAgentActionSOAttributes = AgentActionSOAttributes | AgentPolicyActionSOAttributes;

export interface NewAgentEvent {
type: 'STATE' | 'ERROR' | 'ACTION_RESULT' | 'ACTION';
subtype: // State
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
import {
Agent,
AgentAction,
NewAgentAction,
NewAgentEvent,
AgentEvent,
AgentStatus,
AgentType,
NewAgentAction,
} from '../models';

export interface GetAgentsRequest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { RequestHandler } from 'kibana/server';
import { TypeOf } from '@kbn/config-schema';
import { PostNewAgentActionRequestSchema } from '../../types/rest_spec';
import { ActionsService } from '../../services/agents';
import { NewAgentAction } from '../../../common/types/models';
import { PostNewAgentActionResponse } from '../../../common/types/rest_spec';

export const postNewAgentActionHandlerBuilder = function (
Expand All @@ -26,7 +25,7 @@ export const postNewAgentActionHandlerBuilder = function (

const agent = await actionsService.getAgent(soClient, request.params.agentId);

const newAgentAction = request.body.action as NewAgentAction;
const newAgentAction = request.body.action;

const savedAgentAction = await actionsService.createAgentAction(soClient, {
created_at: new Date().toISOString(),
Expand Down
3 changes: 3 additions & 0 deletions x-pack/plugins/ingest_manager/server/saved_objects/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,11 @@ const savedObjectTypes: { [key: string]: SavedObjectsType } = {
mappings: {
properties: {
agent_id: { type: 'keyword' },
policy_id: { type: 'keyword' },
policy_revision: { type: 'integer' },
type: { type: 'keyword' },
data: { type: 'binary' },
ack_data: { type: 'text' },
sent_at: { type: 'date' },
created_at: { type: 'date' },
},
Expand Down
32 changes: 31 additions & 1 deletion x-pack/plugins/ingest_manager/server/services/agent_policy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
ListWithKuery,
} from '../types';
import { DeleteAgentPolicyResponse, storedPackagePoliciesToAgentInputs } from '../../common';
import { listAgents } from './agents';
import { createAgentPolicyAction, listAgents } from './agents';
import { packagePolicyService } from './package_policy';
import { outputService } from './output';
import { agentPolicyUpdateEventHandler } from './agent_policy_update';
Expand Down Expand Up @@ -67,6 +67,10 @@ class AgentPolicyService {
updated_by: user ? user.username : 'system',
});

if (options.bumpRevision) {
await this.triggerAgentPolicyUpdatedEvent(soClient, 'updated', id);
}

return (await this.get(soClient, id)) as AgentPolicy;
}

Expand Down Expand Up @@ -383,6 +387,32 @@ class AgentPolicyService {
};
}

public async createFleetPolicyChangeAction(
soClient: SavedObjectsClientContract,
agentPolicyId: string
) {
const policy = await agentPolicyService.getFullAgentPolicy(soClient, agentPolicyId);
if (!policy || !policy.revision) {
return;
}
const packages = policy.inputs.reduce<string[]>((acc, input) => {
const packageName = input.meta?.package?.name;
if (packageName && acc.indexOf(packageName) < 0) {
acc.push(packageName);
}
return acc;
}, []);

await createAgentPolicyAction(soClient, {
type: 'CONFIG_CHANGE',
data: { config: policy } as any,
ack_data: { packages },
created_at: new Date().toISOString(),
policy_id: policy.id,
policy_revision: policy.revision,
});
}

public async getFullAgentPolicy(
soClient: SavedObjectsClientContract,
id: string,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,29 @@ import { SavedObjectsClientContract } from 'src/core/server';
import { generateEnrollmentAPIKey, deleteEnrollmentApiKeyForAgentPolicyId } from './api_keys';
import { unenrollForAgentPolicyId } from './agents';
import { outputService } from './output';
import { agentPolicyService } from './agent_policy';

export async function agentPolicyUpdateEventHandler(
soClient: SavedObjectsClientContract,
action: string,
agentPolicyId: string
) {
const adminUser = await outputService.getAdminUser(soClient);
// If no admin user fleet is not enabled just skip this hook
if (!adminUser) {
const outputId = await outputService.getDefaultOutputId(soClient);
// If no admin user and no default output fleet is not enabled just skip this hook
if (!adminUser || !outputId) {
return;
}

if (action === 'created') {
await generateEnrollmentAPIKey(soClient, {
agentPolicyId,
});
await agentPolicyService.createFleetPolicyChangeAction(soClient, agentPolicyId);
}

if (action === 'updated') {
await agentPolicyService.createFleetPolicyChangeAction(soClient, agentPolicyId);
}

if (action === 'deleted') {
Expand Down
Loading

0 comments on commit 23eaf58

Please sign in to comment.