Skip to content

Commit

Permalink
[Guided onboarding] Security config update (#142886)
Browse files Browse the repository at this point in the history
* [Guided onboarding] Merged alerts and cases steps in the security guide, added isGuidePanelOpen$ to the interface

* [Guided onboarding] Fixed the mock file for the ApiService
  • Loading branch information
yuliacech authored Oct 6, 2022
1 parent 6f92e2e commit 2177c76
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
2 changes: 1 addition & 1 deletion src/plugins/guided_onboarding/common/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
export type GuideId = 'observability' | 'security' | 'search';

export type ObservabilityStepIds = 'add_data' | 'view_dashboard' | 'tour_observability';
export type SecurityStepIds = 'add_data' | 'rules' | 'alerts' | 'cases';
export type SecurityStepIds = 'add_data' | 'rules' | 'alertsCases';
export type SearchStepIds = 'add_data' | 'browse_docs' | 'search_experience';

export type GuideStepIds = ObservabilityStepIds | SecurityStepIds | SearchStepIds;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,8 @@ export const securityConfig: GuideConfig = {
],
},
{
id: 'alerts',
title: 'View Alerts',
descriptionList: [
'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
'Nullam ligula enim, malesuada a finibus vel, cursus sed risus.',
'Vivamus pretium, elit dictum lacinia aliquet, libero nibh dictum enim, a rhoncus leo magna in sapien.',
],
},
{
id: 'cases',
title: 'Cases and investigations',
id: 'alertsCases',
title: 'Alerts and cases',
descriptionList: [
'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
'Nullam ligula enim, malesuada a finibus vel, cursus sed risus.',
Expand Down
1 change: 1 addition & 0 deletions src/plugins/guided_onboarding/public/mocks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const apiServiceMock: jest.Mocked<GuidedOnboardingPluginStart> = {
completeGuideStep: jest.fn(),
isGuidedOnboardingActiveForIntegration$: () => new BehaviorSubject(false),
completeGuidedOnboardingForIntegration: jest.fn(),
isGuidePanelOpen$: new BehaviorSubject(false),
},
};

Expand Down
1 change: 1 addition & 0 deletions src/plugins/guided_onboarding/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export interface GuidedOnboardingApi {
completeGuidedOnboardingForIntegration: (
integration?: string
) => Promise<{ state: GuideState } | undefined>;
isGuidePanelOpen$: Observable<boolean>;
}

export interface StepConfig {
Expand Down

0 comments on commit 2177c76

Please sign in to comment.