Review feedback

elastic · Sep 10, 2020 · 1f46dda · 1f46dda
1 parent 137d0b1
commit 1f46dda
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/x-pack/plugins/apm/common/anomaly_detection.ts b/x-pack/plugins/apm/common/anomaly_detection.ts
@@ -54,11 +54,9 @@ export function getSeverityColor(theme: EuiTheme, severity?: Severity) {
 }
 
 export function getSeverityLabel(severity?: Severity) {
-  let label: string = '';
-
   switch (severity) {
     case Severity.critical:
-      label = i18n.translate(
+      return i18n.translate(
         'xpack.apm.servicesTable.serviceHealthStatus.critical',
         {
           defaultMessage: 'Critical',
@@ -68,7 +66,7 @@ export function getSeverityLabel(severity?: Severity) {
 
     case Severity.major:
     case Severity.minor:
-      label = i18n.translate(
+      return i18n.translate(
         'xpack.apm.servicesTable.serviceHealthStatus.warning',
         {
           defaultMessage: 'Warning',
@@ -77,7 +75,7 @@ export function getSeverityLabel(severity?: Severity) {
       break;
 
     case Severity.warning:
-      label = i18n.translate(
+      return i18n.translate(
         'xpack.apm.servicesTable.serviceHealthStatus.healthy',
         {
           defaultMessage: 'Healthy',
@@ -86,15 +84,14 @@ export function getSeverityLabel(severity?: Severity) {
       break;
 
     default:
-      label = i18n.translate(
+      return i18n.translate(
         'xpack.apm.servicesTable.serviceHealthStatus.unknown',
         {
           defaultMessage: 'Unknown',
         }
       );
       break;
   }
-  return label;
 }
 
 export const ML_ERRORS = {

diff --git a/x-pack/plugins/apm/server/lib/helpers/get_bucket_size/index.ts b/x-pack/plugins/apm/server/lib/helpers/get_bucket_size/index.ts
@@ -7,8 +7,6 @@
 import moment from 'moment';
 // @ts-expect-error
 import { calculateAuto } from './calculate_auto';
-// @ts-expect-error
-import { unitToSeconds } from './unit_to_seconds';
 
 export function getBucketSize(
   start: number,