Update from feedback

elastic · May 6, 2020 · 1ee6820 · 1ee6820
1 parent 666f28e
commit 1ee6820
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/pie_visualization/render_function.tsx b/x-pack/plugins/lens/public/pie_visualization/render_function.tsx
@@ -109,7 +109,10 @@ export function PieComponent(
         return String(d);
       },
       fillLabel:
-        isDarkMode && shape === 'treemap' && layerIndex < columnGroups.length - 1
+        isDarkMode &&
+        shape === 'treemap' &&
+        layerIndex < columnGroups.length - 1 &&
+        categoryDisplay !== 'hide'
           ? { ...fillLabel, textColor: euiDarkVars.euiTextColor }
           : fillLabel,
       shape: {
@@ -252,6 +255,7 @@ export function PieComponent(
           valueFormatter={(d: number) => (hideLabels ? '' : formatters[metricColumn.id].convert(d))}
           layers={layers}
           config={config}
+          topGroove={hideLabels || categoryDisplay === 'hide' ? 0 : undefined}
         />
       </Chart>
     </VisualizationContainer>

diff --git a/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx b/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx
@@ -73,7 +73,7 @@ const categoryOptionsTreemap: Array<{
   {
     value: 'default',
     inputDisplay: i18n.translate('xpack.lens.pieChart.showTreemapCategoriesLabel', {
-      defaultMessage: 'Show',
+      defaultMessage: 'Show labels',
     }),
   },
   {