[x-pack/test] convert PO to typescript, improve find/testSubject usage (

#77389)
elastic · Sep 15, 2020 · 1ab229a · 1ab229a
1 parent 0574efa
commit 1ab229a
Show file tree

Hide file tree

Showing 18 changed files with 121 additions and 134 deletions.
diff --git a/test/functional/page_objects/vega_chart_page.ts b/test/functional/page_objects/vega_chart_page.ts
@@ -17,7 +17,6 @@
  * under the License.
  */
 
-import { Key } from 'selenium-webdriver';
 import expect from '@kbn/expect';
 import { FtrProviderContext } from '../ftr_provider_context';
 
@@ -94,9 +93,9 @@ export function VegaChartPageProvider({
       const aceGutter = await this.getAceGutterContainer();
 
       await aceGutter.doubleClick();
-      await browser.pressKeys(Key.RIGHT);
-      await browser.pressKeys(Key.LEFT);
-      await browser.pressKeys(Key.LEFT);
+      await browser.pressKeys(browser.keys.RIGHT);
+      await browser.pressKeys(browser.keys.LEFT);
+      await browser.pressKeys(browser.keys.LEFT);
       await browser.pressKeys(text);
     }
 
@@ -105,7 +104,7 @@ export function VegaChartPageProvider({
 
       await retry.try(async () => {
         await aceGutter.doubleClick();
-        await browser.pressKeys(Key.BACK_SPACE);
+        await browser.pressKeys(browser.keys.BACK_SPACE);
 
         expect(await this.getSpec()).to.be('');
       });

diff --git a/...ional/page_objects/accountsetting_page.js → ...nal/page_objects/account_settings_page.ts b/...ional/page_objects/accountsetting_page.js → ...nal/page_objects/account_settings_page.ts
@@ -4,15 +4,15 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-//import { map as mapAsync } from 'bluebird';
 import expect from '@kbn/expect';
+import { FtrProviderContext } from '../ftr_provider_context';
 
-export function AccountSettingProvider({ getService }) {
+export function AccountSettingProvider({ getService }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
   const userMenu = getService('userMenu');
 
   class AccountSettingsPage {
-    async verifyAccountSettings(expectedEmail, expectedUserName) {
+    async verifyAccountSettings(expectedEmail: string, expectedUserName: string) {
       await userMenu.clickProvileLink();
 
       const usernameField = await testSubjects.find('username');
@@ -25,7 +25,7 @@ export function AccountSettingProvider({ getService }) {
       await userMenu.closeMenu();
     }
 
-    async changePassword(currentPassword, newPassword) {
+    async changePassword(currentPassword: string, newPassword: string) {
       await testSubjects.setValue('currentPassword', currentPassword);
       await testSubjects.setValue('newPassword', newPassword);
       await testSubjects.setValue('confirmNewPassword', newPassword);