adds extra check to see that the selected number of signals is correct

elastic · Mar 12, 2020 · 193be04 · 193be04
1 parent bd9b7b2
commit 193be04
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/x-pack/legacy/plugins/siem/cypress/integration/detections.spec.ts b/x-pack/legacy/plugins/siem/cypress/integration/detections.spec.ts
@@ -3,7 +3,12 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import { NUMBER_OF_SIGNALS, SHOWING_SIGNALS, SIGNALS } from '../screens/detections';
+import {
+  NUMBER_OF_SIGNALS,
+  SELECTED_SIGNALS,
+  SHOWING_SIGNALS,
+  SIGNALS,
+} from '../screens/detections';
 
 import {
   closeSignals,
@@ -39,6 +44,11 @@ describe('Detections', () => {
 
         const numberOfSignalsToBeClosed = 3;
         selectNumberOfSignals(numberOfSignalsToBeClosed);
+
+        cy.get(SELECTED_SIGNALS)
+          .invoke('text')
+          .should('eql', `Selected ${numberOfSignalsToBeClosed} signals`);
+
         closeSignals();
         waitForSignals();
         cy.reload();
@@ -65,6 +75,11 @@ describe('Detections', () => {
 
         const numberOfSignalsToBeOpened = 1;
         selectNumberOfSignals(numberOfSignalsToBeOpened);
+
+        cy.get(SELECTED_SIGNALS)
+          .invoke('text')
+          .should('eql', `Selected ${numberOfSignalsToBeOpened} signal`);
+
         openSignals();
         waitForSignals();
         cy.reload();

diff --git a/x-pack/legacy/plugins/siem/cypress/screens/detections.ts b/x-pack/legacy/plugins/siem/cypress/screens/detections.ts
@@ -14,7 +14,9 @@ export const NUMBER_OF_SIGNALS = '[data-test-subj="server-side-event-count"]';
 
 export const OPEN_CLOSE_SIGNALS_BTN = '[data-test-subj="openCloseSignal"] .siemLinkIcon__label';
 
-export const OPENED_SIGNALS_BTN = '[data-test-subj=openSignals]';
+export const OPENED_SIGNALS_BTN = '[data-test-subj="openSignals"]';
+
+export const SELECTED_SIGNALS = '[data-test-subj="selectedSignals"]';
 
 export const SHOWING_SIGNALS = '[data-test-subj="showingSignals"]';
 

diff --git a/...ugins/siem/public/pages/detection_engine/components/signals/signals_utility_bar/index.tsx b/...ugins/siem/public/pages/detection_engine/components/signals/signals_utility_bar/index.tsx
@@ -73,7 +73,7 @@ const SignalsUtilityBarComponent: React.FC<SignalsUtilityBarProps> = ({
           <UtilityBarGroup>
             {canUserCRUD && hasIndexWrite && (
               <>
-                <UtilityBarText>
+                <UtilityBarText dataTestSubj="selectedSignals">
                   {i18n.SELECTED_SIGNALS(
                     showClearSelection ? formattedTotalCount : formattedSelectedEventsCount,
                     showClearSelection ? totalCount : Object.keys(selectedEventIds).length