Skip to content

Commit

Permalink
[Datatable] Removes the old implementation (#111339)
Browse files Browse the repository at this point in the history
* [Datatable] Removes the angular implementation

* Fix i18n errors

* Fix types

* Remove unecessary funtional tests

* Fix documentation

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
stratoula and kibanamachine authored Sep 14, 2021
1 parent 43ea293 commit 182533f
Show file tree
Hide file tree
Showing 47 changed files with 14 additions and 4,202 deletions.
1 change: 0 additions & 1 deletion scripts/functional_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const alwaysImportedTests = [
require.resolve('../test/ui_capabilities/newsfeed_err/config.ts'),
require.resolve('../test/new_visualize_flow/config.ts'),
require.resolve('../test/security_functional/config.ts'),
require.resolve('../test/functional/config.legacy.ts'),
];
// eslint-disable-next-line no-restricted-syntax
const onlyNotInCoverageTests = [
Expand Down
7 changes: 1 addition & 6 deletions src/plugins/vis_type_table/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
Contains the data table visualization, that allows presenting data in a simple table format.

By default a new version of visualization will be used. To use the previous version of visualization the config must have the `vis_type_table.legacyVisEnabled: true` setting
configured in `kibana.dev.yml` or `kibana.yml`, as shown in the example below:

```yaml
vis_type_table.legacyVisEnabled: true
```
Aggregation-based datatable visualizations use the EuiDataGrid component.
5 changes: 1 addition & 4 deletions src/plugins/vis_type_table/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,4 @@
* Side Public License, v 1.
*/

// TODO: https://github.com/elastic/kibana/issues/110891
/* eslint-disable @kbn/eslint/no_export_all */

export * from './types';
export { AggTypes, TableVisParams, VIS_TYPE_TABLE } from './types';
1 change: 0 additions & 1 deletion src/plugins/vis_type_table/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { schema, TypeOf } from '@kbn/config-schema';

export const configSchema = schema.object({
enabled: schema.boolean({ defaultValue: true }),
legacyVisEnabled: schema.boolean({ defaultValue: false }),
});

export type ConfigSchema = TypeOf<typeof configSchema>;
2 changes: 1 addition & 1 deletion src/plugins/vis_type_table/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
},
"description": "Registers the datatable aggregation-based visualization. Currently it contains two implementations, the one based on EUI datagrid and the angular one. The second one is going to be removed in future minors."
"description": "Registers the datatable aggregation-based visualization."
}
5 changes: 2 additions & 3 deletions src/plugins/vis_type_table/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
* Side Public License, v 1.
*/

import { PluginInitializerContext } from 'kibana/public';
import { TableVisPlugin as Plugin } from './plugin';

export function plugin(initializerContext: PluginInitializerContext) {
return new Plugin(initializerContext);
export function plugin() {
return new Plugin();
}

This file was deleted.

25 changes: 0 additions & 25 deletions src/plugins/vis_type_table/public/legacy/_table_vis.scss

This file was deleted.

42 changes: 0 additions & 42 deletions src/plugins/vis_type_table/public/legacy/agg_table/_agg_table.scss

This file was deleted.

This file was deleted.

34 changes: 0 additions & 34 deletions src/plugins/vis_type_table/public/legacy/agg_table/agg_table.html

This file was deleted.

Loading

0 comments on commit 182533f

Please sign in to comment.