Skip to content

Commit

Permalink
Fix TS
Browse files Browse the repository at this point in the history
  • Loading branch information
maryia-lapata committed Feb 24, 2020
1 parent 41fccfd commit 16a3570
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ function TableOptions({
.filter(col => get(col.aggConfig.type.getFormat(col.aggConfig), 'type.id') === 'number')
.map(({ name }) => ({ value: name, text: name })),
],
[aggs, stateParams.percentageCol, stateParams.dimensions]
[aggs]
);

const isPerPageValid = stateParams.perPage === '' || stateParams.perPage > 0;

useEffect(() => {
setValidity(isPerPageValid);
}, [isPerPageValid]);
}, [isPerPageValid, setValidity]);

useEffect(() => {
if (
Expand All @@ -64,7 +64,7 @@ function TableOptions({
) {
setValue('percentageCol', percentageColumns[0].value);
}
}, [percentageColumns, stateParams.percentageCol]);
}, [percentageColumns, stateParams.percentageCol, setValue]);

return (
<EuiPanel paddingSize="s">
Expand Down

0 comments on commit 16a3570

Please sign in to comment.