Skip to content

Commit

Permalink
[Maps] Show plus sign for term join metrics (#88049)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasneirynck authored Jan 12, 2021
1 parent 3b6453a commit 14d96da
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 7 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export class MetricsExpression extends Component {
fields={this.props.rightFields}
metrics={this.props.metrics}
onChange={this.props.onChange}
allowMultipleMetrics={true}
/>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ test('Should render metrics expression for metrics', () => {
const component = shallow(
<MetricsExpression
{...defaultProps}
rightFields={['foobar', 'prop1']}
metrics={[
{ type: 'count', label: 'my count' }, // should ignore label
{ type: 'max' }, // incomplete - no field, should not be included in expression
Expand Down

0 comments on commit 14d96da

Please sign in to comment.