no message

elastic · Nov 2, 2020 · 14625f1 · 14625f1
1 parent c9c6651
commit 14625f1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/x-pack/plugins/lens/public/drag_drop/drag_drop.test.tsx b/x-pack/plugins/lens/public/drag_drop/drag_drop.test.tsx
@@ -302,10 +302,10 @@ describe('DragDrop', () => {
       component.find('[data-test-subj="lnsDragDrop-reorderableDrop"]').at(2).simulate('dragover');
       expect(component.find('[data-test-subj="lnsDragDrop"]').at(0).prop('style')).toEqual({});
       expect(component.find('[data-test-subj="lnsDragDrop"]').at(1).prop('style')).toEqual({
-        transform: 'translateY(-4px)',
+        transform: 'translateY(-8px)',
       });
       expect(component.find('[data-test-subj="lnsDragDrop"]').at(2).prop('style')).toEqual({
-        transform: 'translateY(-4px)',
+        transform: 'translateY(-8px)',
       });
 
       component.find('[data-test-subj="lnsDragDrop-reorderableDrop"]').at(2).simulate('dragleave');

diff --git a/x-pack/plugins/lens/public/drag_drop/drag_drop.tsx b/x-pack/plugins/lens/public/drag_drop/drag_drop.tsx
@@ -312,17 +312,19 @@ const getKeyboardReorderMessageMoved = (
   prevPosition: number
 ) =>
   i18n.translate('xpack.lens.dragDrop.elementMoved', {
-    defaultMessage: `You have moved the item ${itemLabel} from position {prevPosition} to position {position}`,
+    defaultMessage: `You have moved the item {itemLabel} from position {prevPosition} to position {position}`,
     values: {
+      itemLabel,
       position,
       prevPosition,
     },
   });
 
 const getKeyboardReorderMessageLifted = (itemLabel: string, position: number) =>
   i18n.translate('xpack.lens.dragDrop.elementLifted', {
-    defaultMessage: `You have lifted an item ${itemLabel} in position {position}`,
+    defaultMessage: `You have lifted an item {itemLabel} in position {position}`,
     values: {
+      itemLabel,
       position,
     },
   });

diff --git a/x-pack/plugins/lens/public/drag_drop/providers.tsx b/x-pack/plugins/lens/public/drag_drop/providers.tsx
@@ -171,7 +171,7 @@ export function ReorderProvider({
       <EuiPortal>
         <EuiScreenReaderOnly>
           <div>
-            <p id="lnsDragDrop-reorderAnnouncement" aria-live="assertive">
+            <p id="lnsDragDrop-reorderAnnouncement" aria-live="assertive" aria-atomic={true}>
               {state.keyboardReorderMessage}
             </p>
             <p id={`lnsDragDrop-reorderInstructions-${id}`}>

diff --git a/...k/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.test.tsx b/...k/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.test.tsx
@@ -198,7 +198,8 @@ describe('LayerPanel', () => {
 
       const group = component
         .find(EuiFormRow)
-        .findWhere((e) => e.prop('error') === 'Required dimension');
+        .findWhere((e) => e.prop('error')?.props?.children === 'Required dimension');
+
       expect(group).toHaveLength(1);
     });