i18n feedback

elastic · Apr 6, 2022 · 1435c12 · 1435c12
1 parent 66ced34
commit 1435c12
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 21 deletions.
diff --git a/src/plugins/discover/public/application/main/components/sidebar/discover_field_search.tsx b/src/plugins/discover/public/application/main/components/sidebar/discover_field_search.tsx
@@ -28,7 +28,6 @@ import {
   EuiFilterButton,
   EuiSpacer,
   EuiIcon,
-  EuiPagination,
   EuiBasicTableColumn,
   EuiLink,
   EuiText,
@@ -324,9 +323,17 @@ export function DiscoverFieldSearch({ onChange, value, types, presentFieldTypes
       onClick={onHelpClick}
       data-test-subj="fieldTypesHelpButton"
       className="dscFieldTypesHelp__button"
-      aria-label="Filter type help"
+      aria-label={i18n.translate('discover.fieldTypesPopover.buttonAriaLabel', {
+        defaultMessage: 'Filter type help',
+      })}
     >
-      <EuiIcon type="iInCircle" color="primary" title="Filter type help" />
+      <EuiIcon
+        type="iInCircle"
+        color="primary"
+        title={i18n.translate('discover.fieldTypesPopover.iconTitle', {
+          defaultMessage: 'Filter type help',
+        })}
+      />
     </EuiFilterButton>
   );
 
@@ -401,29 +408,17 @@ export function DiscoverFieldSearch({ onChange, value, types, presentFieldTypes
                 responsive={false}
               />
             </EuiPanel>
-            {/* <EuiSpacer size="s" />
-            {presentFieldTypes.length > FIELD_TYPES_PER_PAGE && (
-              <EuiFlexGroup justifyContent="flexEnd" gutterSize="none" responsive={false}>
-                <EuiFlexItem grow={false}>
-                  <EuiPagination
-                    aria-label={i18n.translate('discover.fieldChooser.paginationAriaLabel', {
-                      defaultMessage: 'Field types navigation',
-                    })}
-                    activePage={curPageIndex}
-                    pageCount={totalPages}
-                    onPageClick={changePageIndex}
-                  />
-                </EuiFlexItem>
-              </EuiFlexGroup>
-            )} */}
             <EuiPanel color="transparent" paddingSize="s">
               <EuiText color="subdued" size="xs">
                 <p>
-                  Learn more about&nbsp;
+                  {i18n.translate('discover.fieldTypesPopover.learnMoreText', {
+                    defaultMessage: 'Learn more about',
+                  })}
+                  &nbsp;
                   <EuiLink href={docLinks.links.discover.fieldTypeHelp}>
                     <FormattedMessage
-                      id="discover.fieldTypesPopover.learnMore"
-                      defaultMessage="field types"
+                      id="discover.fieldTypesPopover.learnMoreLink"
+                      defaultMessage="field types."
                     />
                   </EuiLink>
                 </p>

diff --git a/...ins/discover/public/application/main/components/sidebar/lib/get_field_type_description.ts b/...ins/discover/public/application/main/components/sidebar/lib/get_field_type_description.ts
@@ -22,6 +22,10 @@ export function getFieldTypeDescription(type: string) {
       return i18n.translate('discover.fieldNameDescription.dateField', {
         defaultMessage: 'A date string or the number of seconds or milliseconds since 1/1/1970.',
       });
+    case 'date_range':
+      return i18n.translate('discover.fieldNameDescription.dateField', {
+        defaultMessage: 'Range of date values.',
+      });
     case 'geo_point':
       return i18n.translate('discover.fieldNameDescription.geoPointField', {
         defaultMessage: 'Latitude and longitude points.',
@@ -34,6 +38,10 @@ export function getFieldTypeDescription(type: string) {
       return i18n.translate('discover.fieldNameDescription.ipAddressField', {
         defaultMessage: 'IPv4 and IPv6 addresses.',
       });
+    case 'ip_range':
+      return i18n.translate('discover.fieldNameDescription.ipAddressField', {
+        defaultMessage: 'Range of ip values supporting either IPv4 or IPv6 (or mixed) addresses.',
+      });
     case 'murmur3':
       return i18n.translate('discover.fieldNameDescription.murmur3Field', {
         defaultMessage: 'Field that computes and stores hashes of values.',