[i18n] fix i18nrc parsing (#41741)

* check for translations in file * update template
elastic · Jul 23, 2019 · 131e4c2 · 131e4c2
1 parent 2eb25c2
commit 131e4c2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json b/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json
@@ -1,5 +1,8 @@
 {
   "paths": {
     "<%= camelCase(name) %>": "./"
-  }
+  },
+  "translations": [
+    "translations/zh-CN.json"
+  ]
 }
diff --git a/src/legacy/server/i18n/get_translations_path.js b/src/legacy/server/i18n/get_translations_path.js
@@ -34,10 +34,12 @@ export async function getTranslationPaths({ cwd, glob }) {
     try {
       const content = await readFileAsync(entryFullPath, 'utf8');
       const { translations } = JSON.parse(content);
-      translations.forEach(translation => {
-        const translationFullPath = resolve(pluginBasePath, translation);
-        translationPaths.push(translationFullPath);
-      });
+      if (translations && translations.length) {
+        translations.forEach(translation => {
+          const translationFullPath = resolve(pluginBasePath, translation);
+          translationPaths.push(translationFullPath);
+        });
+      }
     } catch (err) {
       throw new Error(`Failed to parse .i18nrc.json file at ${entryFullPath}`);
     }